Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governor: support multiple stakers #62

Open
moodysalem opened this issue Dec 1, 2024 · 3 comments
Open

governor: support multiple stakers #62

moodysalem opened this issue Dec 1, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@moodysalem
Copy link
Member

in the governor we need to support migration to improved staker contracts. the governor needs to be able to point to multiple staker contracts and add utilize voting weights from any of them.

e.g. you can specify any 'allowed' staker address when voting, and then voters can vote with all of the allowed stakers for which they have staked tokens

keep the old methods so that the contract is backwards compatible by using the current staker as a default staker

@moodysalem moodysalem added the good first issue Good for newcomers label Dec 1, 2024
@Benjtalkshow
Copy link

Hello @moodysalem
Can i give this a try. Since it is labelled good first issue i believe i can handle it

@baitcode
Copy link

baitcode commented Dec 1, 2024

@moodysalem
I'd like to take this issue.

I would:

  • Add staker addresses into new proposal config field.
  • Update proposal config version in Governor constructor
  • Change vote function flow if new proposal config appears and stakers field is filled

@moodysalem
Copy link
Member Author

Accepted @baitcode

Interesting to put it into config, I was imagining the governor would have a mapping. I generally avoid storing arrays, what would the benefit be of putting it in config? I don't think there is a big advantage to removing the old versions, for example

@moodysalem I'd like to take this issue.

I would:

  • Add staker addresses into new proposal config field.
  • Update proposal config version in Governor constructor
  • Change vote function flow if new proposal config appears and stakers field is filled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants