-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This plugin made discord ban my IP address #450
Comments
Same here:
How do I disable this behaviour? |
This is an issue that has been around for a while; right now the only fix seems to be to disable 'Fetch unread messages when account connects' in the Advanced tab of the configuration, though you have to do that before connecting. It seems to be that pre-fetch that gets Discord upset about going over the rate limits. Unfortunately, especially since you seem to want to use this primarily for private messages, disabling that option means that the plugin won't fetch any private messages that have arrived while you're offline. It also disables messages tagged to you (or @everyone or any group you're a part of) in other servers, but for me the biggest issue is that it doesn't grab private messages when that option is turned off. But at least the other Pidgin capabilities work. |
I am getting tempbanned right and left because of that. @EionRobb please please please fix it! |
seems like that toggle does absolutely nothing cause my pidgin just spams tabs / windows when logging in (with setting toggled to off while adding the account) (joined a lot of servers so yeah) is it not possible to just not open chat windows automaticly |
It does not work. Does anyone have an old DLL that doesn't fetch history at all? |
The thing is that AFAIK fetch unread ignore muted status on channels, while people usuallly only want to know mentions and new PM, so it uses a lotof space/bandwidth... add to that an unstable connection, status not being kept and the same data being resent... rate limits gets reached. |
The correct way to fix it is to support rate limits |
This has gotten worse in the last couple of days. Now I get automatically rate-limited whenever my old rate limit expires. What the hell. At this rate, I might as well take matters into my own hand and look into the code. |
I decided to take matters into my own hands. |
Thank you @Metalhead33! |
There's a dll build of that PR at https://github.com/EionRobb/purple-discord/actions/runs/11470276591/artifacts/2091519359 if you want to try it out @LurkerHub |
Unfortunately, that version monopolized the CPU and made Pidgin lag like it was running on a 4.77MHz 8088. The log was full of
Edit: |
Strange. For me, the plugin works just fine.... except that I don't get any of the Rate Limit-related messages in the debug console, which is weird. However, ever since it, I have not run into a rate limit error. Makes me think my code didn't think anything, and that it's just a placebo effect. |
I am subscribe to several servers. Maybe you just didn't hit the combination that makes it hang in a loop. |
@LurkerHub I am a member of 44 servers. Granted, I turned off "Fetch unread chat messages when account connects" and "Open chat when you are mentioned". I didn't test it with those options turned on. |
I am pretty sure that we have at least some non-intersecting servers, and with Discord adding features right and left, there may be messages that trigger that bevaviour.
There you go! I have both turned on. |
Can you please take a look? |
Any news? |
@LurkerHub Sorry, I don't feel like trying it out with those features turned on, because I don't want to risk losing my one and only Discord account :) |
|
Looks like we have a problem. I still keep getting rate-limited despite using my own modified version of the plugin. It looks like this issue has the answer: the rate limits are only visible for bots, not for regular users. Thanks, Discord! |
Fingers crossed that the newest version by me will make rate limiting even rarer. My code changes so far haven't been particularly invasive, but if I get another tempban, I might have to resort to more invasive measures, such as some kind of queue. The next time I get a tempban, I will program in some sort of FIFO queue or event loop. I have already begun working on an alternate branch for this very purpose, but it does not work yet. Otherwise, if even that fails to work, I will truly be out of options. |
I really appreciate your efforts, @Metalhead33, thank you very much for tackling this issue! |
|
|
Plugin worked, perhaps a little too well. I've been IP banned on discord and can only use discord from my phone through mobile data. Didn't even send any messages via pidgin.
Appear to have gone up against their rate limits https://discord.com/developers/docs/topics/rate-limits
Also I was hoping for a plugin that just did private messages, instead got one that showed me mostly messages from servers I have muted.
The text was updated successfully, but these errors were encountered: