Goldport doesn't split after death

[Eein]

may be a weird state issue

Replicate: Die before entering goldport, then enter goldport

Notes:

• check current.zoneId and old.zoneId for hints
• there may be a old.zoneId equal to zero (bad pointer potentially) that causes this issue.

we optimize the looping by:

  // Enter & Exit Area
  if (old.zoneID != current.zoneID && old.zoneID != 0) {
    // Enter Area
    if (vars.AreaZoneIDs.ContainsKey(current.zoneID) && current.gameState == 2 && old.gameState == 2 && vars.Split("enter_" + current.zoneID)) {
      return true;
    }
    // Exit Area
    if (vars.AreaZoneIDs.ContainsKey(old.zoneID) && (old.gameState == 2 || old.gameState == 4) && vars.Split("exit_" + old.zoneID)) {
      return true;
    }
  }

on the wasm splitter it does not do this as i've deoptimized this:

    if SHRINES.contains_key(&vars.zone_id.current)
        && vars.game_state.current == 5
        && vars.game_state.old == 2
    {
        if let Some(shrine) = SHRINES.get(&vars.zone_id.current) {
            let key = format!("get_{}", vars.name_to_key(&shrine));
            return vars.split(&key);
        }
    }

    // Advanced Job Fights
    if ADVANCED_JOB_FIGHTS.contains_key(&vars.zone_id.current)
        && vars.game_state.current == 5
        && vars.game_state.old == 6
    {
        if let Some(advanced_job) = ADVANCED_JOB_FIGHTS.get(&vars.zone_id.current) {
            let key = format!("advanced_job_fight_{}", vars.name_to_key(&advanced_job));
            return vars.split(&key);
        }
    }