-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority settings missing? #48
Comments
So I've solved the issue by doing the following quick fix: In the end of Push/Notification->getBody() I simply added: $request['priority'] = "high"; Now; you might want to consider extend this within your management getters/settes to make this a real feature. This made my notifications go in warp speed no matter of the devices state (I use cordova). Also for housekeeping purposes 😃 the naming of function getBody() in this class is contradictory as it clashes with setBody(..) and it is not exactly the same type of "body" these two are playing around with (I managed to figure this out when I tried manually to build the full payload array body but the setter function just manages the message body). My Regards to all for the nice work with the API once again! |
Hi @lukasza67 |
How about renaming getBody() to buildJsonRequest() and leaving behind a deprecated getBody() that just redirects and will be removed in the next major release? |
I'd also need the priority. I believe I could put together a PR if that helps. |
As discussed on EdwinHoksberg#48. This is a user-visible breaking API change, though most users probably won't care, as they use FcmClient::send() instead. Also document the NotificationException thrown from there, which existed before but just wasn't documented (not a breaking change).
Hello and thanks for a great work!
I have been going through the documentation and it seams that there is no way of setting the message priority for the notification. As it is now it sends with no settings and it gets "normal" priority by default at FCM-level. Or did I miss to set it manually somewhere?
I think this is a very important feature as on battery saving mode or locked screen the notification is now delayed until the user becomes active with the display.
The text was updated successfully, but these errors were encountered: