-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cpn): fetch maxlibqt from forked repo at compile time #4249
Conversation
Wouldn't it make more sense to fork that repo, add our changes in form of commits on that repo, and either use CMake |
That would provide better attribution but would need an EdgeTx admin to fork and grant permissions for devs to modify. |
I forked the repo into EdgeTX Org and invited you as "Maintainer". |
Merged fix for the conditional test into maxLibQt forked repo PR#1 |
Merged fix for the macos compile error into maxLibQt forked repo EdgeTX/maxLibQt#2 |
@raphaelcoeffic revamped to fetch patched forked repo |
@elecpower would you mind if I make a linear history out of your merges on that new repo? I believe it would be easier to handle in case the upstream repo ever gets updated. Edit: done |
26a57c7
to
f2b6d3f
Compare
Summary of changes: