Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MPM module status #4198

Merged
merged 2 commits into from
Oct 15, 2023
Merged

fix: MPM module status #4198

merged 2 commits into from
Oct 15, 2023

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Oct 13, 2023

We should only consider whether or not the MPM has a working telemetry link.

Fixes an issue introduced in #3822

Fixes #4197, resolves #1187

@TheIsotopes TheIsotopes mentioned this pull request Oct 13, 2023
1 task
@richardclli richardclli added this to the 2.10 milestone Oct 14, 2023
@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Oct 14, 2023
@pfeerick
Copy link
Member

pfeerick commented Oct 14, 2023

This fixes the first part of the issue - TR("Disable int.", "Disable internal RF") being shown all the time on colorlcd and B&W w/ internal MPM, but now it says No telemetry as mentioned in #4197. TX16S, Zorro /w internal MPM

@raphaelcoeffic
Copy link
Member Author

This fixes the first part of the issue - TR("Disable int.", "Disable internal RF") being shown all the time on colorlcd and B&W w/ internal MPM, but now it says No telemetry as mentioned in #4197. TX16S, Zorro /w internal MPM

Ok, so it's not just the status display thingy: it actually does not have any valid telemetry status.

We should only consider if the MPM has a working telemetry link or not.
@raphaelcoeffic
Copy link
Member Author

@pfeerick I fixed the second part (in pulses) which has also assuming that S.PORT is used, rather than checking just checking for a RX port in general.

@TheIsotopes
Copy link
Contributor

@raphaelcoeffic @pfeerick
now i tested again and it fixed #4197... thx👍

@raphaelcoeffic
Copy link
Member Author

I sneaked in an implementation for #1187 as well, as @gagarinlg was complaining 🤪

@pfeerick
Copy link
Member

Seems to be working properly now for X9D+2019, TX16S /w MPM, Zorro /w MPM

@pfeerick pfeerick merged commit ee9d50d into main Oct 15, 2023
37 checks passed
@pfeerick pfeerick deleted the fix-mpm-status branch October 15, 2023 06:27
richardclli added a commit that referenced this pull request Nov 2, 2023
richardclli added a commit that referenced this pull request Nov 2, 2023
richardclli added a commit that referenced this pull request Nov 5, 2023
pfeerick pushed a commit that referenced this pull request Nov 7, 2023
pfeerick pushed a commit that referenced this pull request Nov 7, 2023
pfeerick pushed a commit that referenced this pull request Nov 10, 2023
pfeerick pushed a commit that referenced this pull request Nov 12, 2023
pfeerick pushed a commit that referenced this pull request Nov 12, 2023
richardclli added a commit that referenced this pull request Dec 3, 2023
richardclli added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no telemetry on my zorro R9M/FLEX colorlcd has missing options
4 participants