Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(color): Slider styling and tick marks. #4125

Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat(color): Slider styling and tick marks. #4125

merged 3 commits into from
Oct 16, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Sep 28, 2023 •
edited by pfeerick
Loading

Fixes #4118 and fixes #4119

@pfeerick pfeerick added UX-UI Related to user experience (UX) or user interface (UI) behaviour color Related generally to color LCD radios labels Sep 29, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 6, 2023
@pfeerick pfeerick self-requested a review October 13, 2023 10:45
pfeerick
pfeerick approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on TX16S (i.e. for the various sliders in Radio Settings -> Sound, Haptic, Backlight, Variometer, which is pretty much the only place that control is used atm).

@pfeerick pfeerick merged commit 661542a into EdgeTX:main Oct 16, 2023
37 checks passed
@pfeerick pfeerick mentioned this pull request Oct 16, 2023
Merged
@philmoz philmoz deleted the slider-styling branch January 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

Fix UI Slider Styling Hash Marks for Configuration Sliders
2 participants
@philmoz @pfeerick