Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trainer virtual switch #3937

Merged
merged 3 commits into from
Oct 15, 2023
Merged

feat: add trainer virtual switch #3937

merged 3 commits into from
Oct 15, 2023

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Aug 14, 2023

Asked for on RCGroups

This provide a virtual switch indicating when a trainer link is active.

The switch is functionality does not depend of trainer type (all work), and can only be ON on the master radio (as the slave radio has no way to know if a master is listening to it)

@elecpower
Copy link
Collaborator

elecpower commented Aug 14, 2023

Is there any need to write this to yaml as I interpret it as being a condition and there is no need for persistence?

@3djc
Copy link
Collaborator Author

3djc commented Aug 14, 2023

I think there is a need for yaml:
image

you can also use it to change rates for example when trainer is active
image

image

@elecpower
Copy link
Collaborator

Use cases help my understanding. Therefore if

can only be ON on master radio (slave radio have no way to know if a master is there listening to it)

then should the switch not be listed/available when trainer mode set to slave?

@3djc
Copy link
Collaborator Author

3djc commented Aug 14, 2023

I wondered about that too, but I felt there was more risk of confusion if a switch was to disappear based on trainer setup (especially in mixers lines). If you are slave, it will just never come true, but remains valid nonetheless

@pfeerick pfeerick added the enhancement ✨ New feature or request label Oct 8, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 8, 2023
@pfeerick pfeerick self-requested a review October 13, 2023 10:40
@pfeerick
Copy link
Member

I tried the hard-wired trainer on X9D+2019, TX16S and Zorro, with a special function that beeps while the trainer is active... worked perfectly, as well as companion read/write. So now I get some form of audio prompt when the trainer connects, while it's active, and when it disconnects (if the audio files are present).

I just had a thought... we protect the user against being able to power down while USB connected or a telemetry RF link active... but not with the trainer active? Something to think about?

@pfeerick pfeerick merged commit d396b38 into main Oct 15, 2023
40 checks passed
@pfeerick pfeerick deleted the 3djc/trainer-virtual-switch branch October 15, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants