Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!" entries missing when using PgUp/Dn to preselect switchgroup #3106

Closed
1 task done
ParkerEde opened this issue Jan 25, 2023 · 4 comments · Fixed by #4104
Closed
1 task done

"!" entries missing when using PgUp/Dn to preselect switchgroup #3106

ParkerEde opened this issue Jan 25, 2023 · 4 comments · Fixed by #4104
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios

Comments

@ParkerEde
Copy link
Contributor

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

If I am in a switch selection, e.g. in the special functions, and select a group there with the PgUp/Dn key, I have no possibility to select the entries with the "!"

before using PgUp/Dn:
screenshot_x10express_23-01-25_11-02-00

after using PgUp/Dn:
screenshot_x10express_23-01-25_11-04-08

Expected Behavior

with PgDn/Up preselection, the "!" entries should also be selectable.

Steps To Reproduce

  1. open special function
  2. edit an SF
  3. Enter switch selection
  4. Press PgDn/Up button to preselct a switchgroup
  5. try to select !SA- or any else "!" entry

Version

Nightly (Please give date/commit below)

Transmitter

FrSky X10 Express / X10S Express (ACCESS)

Anything else?

all versions

@ParkerEde ParkerEde added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jan 25, 2023
@pfeerick pfeerick added color Related generally to color LCD radios and removed triage Bug report awaiting review / sorting labels Jan 25, 2023
@pfeerick
Copy link
Member

pfeerick commented Jan 25, 2023

While that is correct, the workaround to then get inverted entries is to either long ENTER or long press on the field once you've selected the "normal" version of it. I'm not sure the best way to resolve this... might leave it for @JimB40 to mull over... as keeping the inverted version of all the switches effectively doubles the lengths of the lists - I wonder if we should only have the normal version and rely on the long press to invert them?

@eshifri
Copy link
Contributor

eshifri commented Jan 25, 2023

I would say the long press is a preferred way to handle this: the switch lists are long enough even without inverted versions.

@ParkerEde
Copy link
Contributor Author

The ENTER long press is also quite practical and a good solution. The only problem is that no one will figure it out unless they are told. Should we possibly give a hint somewhere?

@philmoz
Copy link
Collaborator

philmoz commented Dec 13, 2023

This can probably be closed (PR #4104)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
4 participants