[ODS-5991] Improve error message (#840)

* Improve error message * Fix Postman Tests
Ed-Fi-Alliance-OSS · Oct 5, 2023 · 0abd7f5 · 0abd7f5
1 parent 271edc5
commit 0abd7f5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 17 deletions.
diff --git a/.../EdFi.Ods.Common/Attributes/NoUnsuppliedRequiredMembersWithMeaningfulDefaultsAttribute.cs b/.../EdFi.Ods.Common/Attributes/NoUnsuppliedRequiredMembersWithMeaningfulDefaultsAttribute.cs
@@ -17,7 +17,7 @@ protected override ValidationResult IsValid(object value, ValidationContext vali
             {
                 if(resource.GetUnassignedMemberNames().Any())
                 {
-                    return new ValidationResult("Required value not explicitly assigned.", resource.GetUnassignedMemberNames());
+                    return new ValidationResult("Required", resource.GetUnassignedMemberNames());
                 }
             }
 

diff --git a/...man Test Suite/Ed-Fi ODS-API Integration Test Suite ResponseTests.postman_collection.json b/...man Test Suite/Ed-Fi ODS-API Integration Test Suite ResponseTests.postman_collection.json
@@ -5211,7 +5211,7 @@
 															"\r",
 															"pm.test(\"Should return a message indicating that Validation failed. TotalInstructionalDays is not explicitly assigned\", () => {\r",
 															"    const responseItem = pm.response.json();\r",
-															"    pm.expect(responseItem.modelState[\"request.TotalInstructionalDays\"][0]).to.include(\"Required value not explicitly assigned.\");\r",
+															"    pm.expect(responseItem.modelState[\"request.TotalInstructionalDays\"][0]).to.include(\"Required\");\r",
 															"});"
 														],
 														"type": "text/javascript"

diff --git a/Postman Test Suite/Ed-Fi ODS-API Integration Test Suite.postman_collection.json b/Postman Test Suite/Ed-Fi ODS-API Integration Test Suite.postman_collection.json
@@ -6449,9 +6449,7 @@
 													"        return (message === expectedErrorMessage1);\r",
 													"    });\r",
 													"\r",
-													"    if (request && request.FiscalYear) {\r",
-													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"]).to.contain(\"Required value not explicitly assigned.\");\r",
-													"    }\r",
+													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"][0]).to.equal(\"Required\");\r",
 													"});"
 												],
 												"type": "text/javascript"
@@ -6528,9 +6526,7 @@
 													"        return (message === expectedErrorMessage1);\r",
 													"    });\r",
 													"\r",
-													"    if (request && request.FiscalYear) {\r",
-													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"]).to.contain(\"Required value not explicitly assigned.\");\r",
-													"    }\r",
+													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"][0]).to.equal(\"Required\");\r",
 													"});"
 												],
 												"type": "text/javascript"
@@ -6607,9 +6603,7 @@
 													"        return (message === expectedErrorMessage1);\r",
 													"    });\r",
 													"\r",
-													"    if (request && request.FiscalYear) {\r",
-													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"]).to.contain(\"Required value not explicitly assigned.\");\r",
-													"    }\r",
+													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"][0]).to.equal(\"Required\");\r",
 													"});"
 												],
 												"type": "text/javascript"
@@ -6957,13 +6951,10 @@
 													"\r",
 													"    const responseItem = pm.response.json();\r",
 													"    const expectedErrorMessage1 = \"The request is invalid.\";\r",
-													"    pm.expect(responseItem.message).to.satisfy(function (message) {\r",
-													"        return (message === expectedErrorMessage1);\r",
-													"    });\r",
+													"    pm.expect(responseItem.message).to.equal(expectedErrorMessage1);\r",
+													"\r",
+													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"][0]).to.equal(\"Required\");\r",
 													"\r",
-													"    if (request && request.FiscalYear) {\r",
-													"    pm.expect(responseItem.modelState[\"request.FiscalYear\"]).to.contain(\"Required value not explicitly assigned.\");\r",
-													"    }\r",
 													"});"
 												],
 												"type": "text/javascript"
-Original file line number
+Diff line change
@@ Expand Up @@
                 {
                     if(resource.GetUnassignedMemberNames().Any())
                     {
-                        return new ValidationResult("Required value not explicitly assigned.", resource.GetUnassignedMemberNames());
+                        return new ValidationResult("Required", resource.GetUnassignedMemberNames());
                     }
                 }
@@ Expand Down @@