Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot On Separate Process #96

Open
kelvinmwinuka opened this issue Aug 17, 2024 · 0 comments
Open

Snapshot On Separate Process #96

kelvinmwinuka opened this issue Aug 17, 2024 · 0 comments
Assignees
Labels
advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic enhancement New feature or request

Comments

@kelvinmwinuka
Copy link
Collaborator

At the moment, EchoVault copies the entire store and then runs a snapshot on a goroutine in the same process. This has the effect of (almost) doubling the memory usage of the current process when the entire store is copied.

The idea is to create a new EchoVault process using exec.Command, passing the state to this new process and creating the snapshot in the new process. This should prevent the current process from blowing up in memory usage.

@kelvinmwinuka kelvinmwinuka added enhancement New feature or request advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic labels Aug 17, 2024
@kelvinmwinuka kelvinmwinuka self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant