Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HELLO command #54

Closed
kelvinmwinuka opened this issue Jun 15, 2024 · 1 comment · Fixed by #83
Closed

Implement HELLO command #54

kelvinmwinuka opened this issue Jun 15, 2024 · 1 comment · Fixed by #83
Labels
advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic enhancement New feature or request

Comments

@kelvinmwinuka
Copy link
Collaborator

kelvinmwinuka commented Jun 15, 2024

Implement HELLO command that modifies the connection's RESP version and optionally authenticates the connection.
Reference: https://redis.io/docs/latest/commands/hello/

Client-Server Spec:

Command File: ./internal/modules/connection/commands.go
Test File: ./internal/modules/connection/commands_test.go

Command: hello
Module: constants.ConnectionModule
Categories: constants.ConnectionCategory, constants.FastCategory
Description: (HELLO [protover [AUTH username password] [SETNAME clientname]]) Switch to a different protocol, optionally authenticating and setting the connection's name, or provide a contextual client report.
Sync: false

@kelvinmwinuka kelvinmwinuka added enhancement New feature or request advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic labels Jun 15, 2024
@kelvinmwinuka
Copy link
Collaborator Author

Working on this

@kelvinmwinuka kelvinmwinuka linked a pull request Jul 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced An advanced enhancement requiring deep knowledge of the codebase and/or a particular topic enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant