Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax assumption of hourly data #95

Open
leifdenby opened this issue Dec 3, 2020 · 5 comments
Open

Relax assumption of hourly data #95

leifdenby opened this issue Dec 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@leifdenby
Copy link
Contributor

Creating trajectories:

  • Add metadata to NetCDF output
  • Improve linear trajectory to work with haversine functions and actual velocities
  • Relax assumption of hourly data?
@leifdenby leifdenby added the enhancement New feature or request label Dec 3, 2020
@sjboeing
Copy link
Contributor

sjboeing commented Dec 4, 2020

I think relaxing the assumption of hourly data may be the trickiest of these to test well. The rest could certainly be part of a first tagged version.

@sjboeing
Copy link
Contributor

sjboeing commented Dec 4, 2020

It looks like we are already using the haversine function in:
extrapolate_posn_with_fixed_velocity

@leifdenby
Copy link
Contributor Author

ok, so I'll make an issue to track the idea of making the improvement to "relax assumption of hourly data"? I don't quite understand what that actually means. We compute the time increments explicitly, so we should be able to support input with different time resolution already, no? Or is this referring to be able to interpolate in time?

@sjboeing
Copy link
Contributor

sjboeing commented Jan 7, 2021

I agree that as long as time increments are explicit everywhere, there should not be a problem in changing the input time resolution. We would need to check if there aren't any explicit references to the hourly character of the data Maybe we can test this by using 3-hourly input data? I would leave any time interpolation to beyond v0.1.0.

@sjboeing
Copy link
Contributor

@leifdenby: changing the title as I think the other points (including NetCDF metadata) have now been addressed.

@sjboeing sjboeing changed the title Improvements mentioned in sourcecode Relax assumption of hourly data Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants