Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulations over land/topography #63

Open
sjboeing opened this issue Oct 2, 2020 · 8 comments
Open

Simulations over land/topography #63

sjboeing opened this issue Oct 2, 2020 · 8 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@sjboeing
Copy link
Contributor

sjboeing commented Oct 2, 2020

No description provided.

@sjboeing sjboeing self-assigned this Oct 2, 2020
@sjboeing
Copy link
Contributor Author

sjboeing commented Oct 2, 2020

  • Use of local vs. averaged profiles for e.g. nudging
  • Dealing with points below/near topography in gradient calculations
  • Input parameters for land-surface model

@leifdenby leifdenby added the enhancement New feature or request label Oct 5, 2020
@sjboeing
Copy link
Contributor Author

Will be adding some example files for Cardington soon

@sjboeing
Copy link
Contributor Author

sjboeing commented Dec 1, 2020

Need to think about what height is 0 for MONC inputs.

@sjboeing sjboeing added this to the v0.1.0 milestone Jan 5, 2021
@sjboeing
Copy link
Contributor Author

@leifdenby: I think this might be best placed as part of the conversion process. For MONC, the local surface is at 0.

@sjboeing
Copy link
Contributor Author

@leifdenby: I now started working on simulations over land again. One of the things I am planning to change is the sampling_mask in the forcings input definition. I would like to give users the choice between "all", "ocean_only" and "land_only". I am not sure if there should be a default choice (all?), or if we should force users to specify it. The latter may be the better option, as it prevents users being unaware of the options. What do you think?
While looking into this, I came across the following in the forcing INPUT_REQUIRED_FIELDS: time_sampling_method=(None, "str"). I suppose this is correct, and should not be time_sampling_method=(None, str), but let me know if this needs to change.

@sjboeing
Copy link
Contributor Author

Many required changes are in #125. What needs to be added still is a way to ensure the surface is placed at the right level. Thinking about this a bit more today, I think this should already be done before conversion, as we will get the maximum amount of near-surface information by choosing the right height levels at this point.

@leifdenby
Copy link
Contributor

@sjboeing can we close this issue? Or are there still issues to resolved with regarding creating forcings for simulation over land?

@sjboeing
Copy link
Contributor Author

@leifdenby: I think we should not do anything before 0.1.0 anymore, but may want to do a fix for non-zero surface height in 0.2.0

@sjboeing sjboeing modified the milestones: v0.1.0, v0.2.0 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants