Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor inconsistencies in KPT variable naming #201

Open
sjboeing opened this issue Feb 15, 2023 · 5 comments
Open

Fix minor inconsistencies in KPT variable naming #201

sjboeing opened this issue Feb 15, 2023 · 5 comments
Milestone

Comments

@sjboeing
Copy link
Contributor

No description provided.

@sjboeing
Copy link
Contributor Author

@SGhZD: let me know the details here, and I will have a look at it.

@SGhZD
Copy link
Collaborator

SGhZD commented Feb 15, 2023

This shows 'variable name in KPT' : 'variable name in DALES'
{ 'qiadv':'iadv', 'qladv':'ladv','pres':'pressure_f','zf':'height_f', 'zh':height_h}

@jchylik
Copy link
Collaborator

jchylik commented Feb 15, 2023

Still there is also an option to just keep the names as they are and include alternative variable loading names in Dales (done that before )
The advantage is that we would be able to use the whole library of cases without changes.

@leifdenby leifdenby added this to the v1.0.0 milestone Apr 20, 2023
@jchylik
Copy link
Collaborator

jchylik commented May 25, 2023

I am still bit puzzled by the variable of half level height.

line 18 in lagtraj/forcings/conversion/targets/kpt.py
"zh": {"units": "m", "long_name": "half level height"},

I thought that the half level height is directly dependent on the array of full level height. Isn't it?

@sjboeing
Copy link
Contributor Author

sjboeing commented Sep 3, 2024

Addressed in #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants