Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure humidities are positive #101

Open
sjboeing opened this issue Dec 15, 2020 · 5 comments
Open

Ensure humidities are positive #101

sjboeing opened this issue Dec 15, 2020 · 5 comments
Assignees
@sjboeing
Labels
enhancement New feature or request
Milestone
v0.2.0

Comments

@sjboeing
Copy link
Contributor

No description provided.

@sjboeing
Copy link
Contributor Author

sjboeing commented Jan 5, 2021

After checking with Leo, this seems OK in the current files. The issue may have been elsewhere.

@sjboeing sjboeing closed this as completed Jan 5, 2021
@sjboeing sjboeing reopened this Jan 6, 2021
@sjboeing
Copy link
Contributor Author

sjboeing commented Jan 6, 2021

Issue seems to be in the hydrometeors, rather than the water vapour field

@sjboeing
Copy link
Contributor Author

sjboeing commented Jan 6, 2021

It probably results from the horizontal interpolation on the EC side not being monotonic.

@leifdenby
Copy link
Contributor

Ok. Does that mean we might need some more sophisticated interpolation routines? Or maybe these needs a bit further digging to understand what ECMWF are doing?

How do you feel about leaving this till v0.2.0? We can release that quite soon if it's quite to do, but I'd like to get a tagged version with the conversion work done so we have a reference point without any further features.

@leifdenby leifdenby added the enhancement New feature or request label Jan 7, 2021
@sjboeing sjboeing self-assigned this Jan 7, 2021
@sjboeing
Copy link
Contributor Author

sjboeing commented Jan 7, 2021

I think we can leave this to 0.2.0, as long as we add it to a list of known issues. It my be related to this issue:
https://confluence.ecmwf.int/display/EMOS/Precipitation
It may not be crucial, as we usually don't initialise the rain fields in LES. One approach would be a correction to the field to ensure all values are 0 or greater early in the pipeline (possibly when the fields are still in their 3D form).

@sjboeing sjboeing added this to the v0.2.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjboeing sjboeing

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@leifdenby @sjboeing