Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate Pypi/conda packages #23

Closed
KrisThielemans opened this issue Sep 28, 2024 · 1 comment · Fixed by #26
Closed

generate Pypi/conda packages #23

KrisThielemans opened this issue Sep 28, 2024 · 1 comment · Fixed by #26
Labels
help wanted Extra attention is needed

Comments

@KrisThielemans
Copy link
Contributor

Good example would be the MRD repo, see microsoft/yardl#108 (comment) for some info.

It looks like for MRD, the generated code is added to the repo, presumably via some actions etc. Usually I don't like adding generated code to a repo, but otherwise we probably need 2 different repos (the model, and the generated code). Suggestions welcome!

@lukepolson
Copy link
Contributor

lukepolson commented Sep 29, 2024

@KrisThielemans it seems like they have a the following actions

  1. Create the environment necessary for using yardl: https://github.com/ismrmrd/mrd/blob/main/.github/actions/configure-mrd-build-environment/action.yml
  2. Build the source code for cpp/python/matlab using yardl (from their .yml files) https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_build.yml
  3. Then some code for (a) publishing to pypi https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_pypi.yml and (b) publishing to conda https://github.com/ismrmrd/mrd/blob/main/.github/workflows/mrd_conda.yml

I'll play around with a forked version of the repository and test-pypi to see if I can get something similar to what they have.

@KrisThielemans KrisThielemans linked a pull request Sep 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants