Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cite_label and cite_string not being applied in shiny #198

Closed
TNRiley opened this issue Aug 1, 2024 · 8 comments
Closed

cite_label and cite_string not being applied in shiny #198

TNRiley opened this issue Aug 1, 2024 · 8 comments
Labels
Bug Something isn't working Shiny Application

Comments

@TNRiley
Copy link
Collaborator

TNRiley commented Aug 1, 2024

This issue appears to be limited to the web shiny. Works fine in the local shiny.

cite_label or cite_string tags are not being applied. This can be seen in the tables and in the exported data.

@TNRiley TNRiley added Bug Something isn't working Shiny Application labels Aug 1, 2024
@LukasWallrich
Copy link
Collaborator

For me, it does not work locally either. It appears that the shiny::observeEvent(input$tbl_out_cell_edit, { is not triggered. Can you recheck it it works for you locally with the latest code? It it no longer works after you update, we should be able to narrow down where it broek

@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 2, 2024

I'm up to date and it's working locally. I'm running the "working_example" vignette and things look good.

@LukasWallrich
Copy link
Collaborator

To double check: you are editing the table in Shiny to add labels and strings, and they show up in the Visualisation page? Can you share your sessionInfo()?

@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 2, 2024

@LukasWallrich sent you that session info and a short .mp4 video to show you what I'm seeing

@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 23, 2024

I'm running things locally and it's not working now, not sure why it had been when I tested earlier. Tested on the same vignette data and others. Also checked locally using both the run_shiny and runshiny. I haven't done any digging on this yet, but wanted to let you know that I'm at least in line with you now.

@LukasWallrich
Copy link
Collaborator

LukasWallrich commented Aug 23, 2024 via email

@TNRiley TNRiley changed the title cite_label and cite_string not being applied in web shiny cite_label and cite_string not being applied in shiny Aug 29, 2024
@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 30, 2024

Found the issue. It was this change that was related to the reimport issue #177. SInce the need for this to work is more important than the re-import I'm reverting the script back to what it had been. I'm working on some videos for the Global Evidence Summit poster. I'm going to re-open #177 and note this.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 30, 2024

reverted to previous script. FYI @LukasWallrich - I'll start looking at another fix for #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Shiny Application
Projects
None yet
Development

No branches or pull requests

2 participants