Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplication crashes Shiny if there are no duplicates #191

Closed
LukasWallrich opened this issue Jul 30, 2024 · 3 comments
Closed

Deduplication crashes Shiny if there are no duplicates #191

LukasWallrich opened this issue Jul 30, 2024 · 3 comments

Comments

@LukasWallrich
Copy link
Collaborator

When I use the tests/testthat/data/1_WoS.ris in the Shiny app (locally and online) and try to de-duplicate it, the app crashes with Warning: Error in ASySD::dedup_citations: object 'unique_citations_with_metadata' not found

Outside the Shiny app, dedup_citations() works on that file. Will try to investigate.

@LukasWallrich
Copy link
Collaborator Author

Actually, that is an issue in ASySD - I will open it there, but keep it open here as well, as it currently breaks the app if users include files without duplicates (admittedly a rare use case)

@LukasWallrich LukasWallrich changed the title Deduplication crashes with example RIS Deduplication crashes Shiny if there are no duplicates Jul 30, 2024
@LukasWallrich
Copy link
Collaborator Author

LukasWallrich commented Jul 30, 2024

Added a PR to ASySD that should resolve this once Kaitlyn merges it: camaradesuk/ASySD#43

@TNRiley
Copy link
Collaborator

TNRiley commented Sep 2, 2024

Just ran this to check and still crashing with a single record upload, but worked fine with two that had no duplicates.
I don't think that this is an issue any longer.

@TNRiley TNRiley closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants