Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package size #159

Open
TNRiley opened this issue Jun 15, 2023 · 7 comments
Open

Package size #159

TNRiley opened this issue Jun 15, 2023 · 7 comments
Assignees
Labels

Comments

@TNRiley
Copy link
Collaborator

TNRiley commented Jun 15, 2023

The current size is 7.2MB and we'll need to get it under 5MB.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Jun 22, 2023

We can start with removing the plot sandbox, the vignette produces a number of plots and tables. I'm not sure if that will have a large impact as it reuses citation data from the screening phase vignette. I'll remove it and test to see where that gets us.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Jun 22, 2023

Removing the plot sandbox did it! I'm not sure exactly what size it's sitting at now but would like to figure that out. We may need to consolidate the vignettes a bit more. The CMD check had a warning for being over 6.4MB, however, the guidelines say that the package should not be over 5MB.

@rootsandberries what are your thoughts on removing the "Assessing Usefulness of Databases for Evidence Synthesis" vignette as it does much the same as the "Source Analysis Across Screening Phases" vignette? Happy to work to make sure that one is meeting all of our needs for the use case.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Jun 22, 2023

Not sure if this is actually fixed. When running the devtools::check(remote = TRUE, manual = TRUE) I get the message Size of tarball: 7725382 bytes, which is 7.7MB... hard to know, but believe we still need to reduce.

@rootsandberries
Copy link
Collaborator

Yes, I think removing "Assessing Usefulness of Databases for Evidence Synthesis" makes a lot of sense. Its very repetitive with "Source Analysis Across Screening Phases" at this point. Hopefully, that will bring the size down sufficiently!

@TNRiley
Copy link
Collaborator Author

TNRiley commented May 30, 2024

The current package size without vignettes is 3.04MB - the vignettes are about 20MB with two (Benchmarking & Source Analysis Across Screening Phases) each at about 9MB each.

Let's discuss what options we might have to trim down vignettes, move vignettes somewhere outside the package, etc. Video vignettes are still planned so we can also point to those and keep them updated pretty easily.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Jul 2, 2024

@rootsandberries I'd like to put our heads together on these vignettes so that we can reduce the size significantly and align them with the use cases that we outline in the paper.

@TNRiley
Copy link
Collaborator Author

TNRiley commented Aug 2, 2024

@rootsandberries and I will put together a few new vignettes and base them on an example of an umbrella review for health, economic, and environmental impacts of wildfires. The search will be for systematic reviews and meta-analyses and wildfires, which should limit the number of results and data in an effort to reduce the size of the vignettes.

We should absolutely keep the current vignettes we have, but shift them over to something like OSF. I'll also work on some video vignettes for the current ones so we can link to those as examples in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants