Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface private subroutines use HCO_GC_ prefix #44

Open
lizziel opened this issue Dec 9, 2024 · 1 comment
Open

Interface private subroutines use HCO_GC_ prefix #44

lizziel opened this issue Dec 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@lizziel
Copy link
Collaborator

lizziel commented Dec 9, 2024

The HEMCO interface in hemco_interface.F90 contains private IRF subroutines that use prefix HCO_GC_. However, this can cause confusion with the HEMCO interface within GEOS-Chem which uses the same prefix convection. I believe the _GC_ in the HEMCO interface for CAM is short for gridded component. _GC_ in GEOS-Chem means GEOS-Chem. I suggest we rename these subroutines in the CAM interface to avoid confusion with GEOS-Chem.

@lizziel lizziel added the enhancement New feature or request label Dec 9, 2024
@lizziel
Copy link
Collaborator Author

lizziel commented Dec 9, 2024

There is a similar naming issue for the public HCOI_ subroutines in hemco_interface.F90. The naming would indicate they are defined in HEMCO but they are actually defined in HEMCO_CESM.

I suggest we replace HCO_GC as well as the HCOI_ prefixes in hemco_interface.F90 with hco_cesm_. This would conform to the standard for other models that use HEMCO, including the HEMCO standalone. The second entry indicates where the subroutine is defined. hco_sa is standalone and is in HEMCO. hco_gc_ is in GEOS-Chem. hco_cesm_ would be in CESM. Core hco_ and hcoi_ subroutines, e.g. hco_run, would be reserved for HEMCO proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant