Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTSM warm start coupling with single column mode. New ne3np4 boundary data for use with SCAM-SE. #2333

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jtruesdal
Copy link
Contributor

Description:

These updates allow CTSM to run in a warm start configuration, allowing interpolation of spun up initial conditions to a single column when running in SCAM mode. These mods are also compatible with the SE grid and also include new defaults for low resolution spectral element (ne3np4) boundary data.

Specific notes:

With the addition of initial condition interpolation CTSM needs access to the original grid in addition to the single column target of the interpolation. A flag and code was added to the interpolation subroutines to interpolate IC data on the CTSM array of nested input grids to a single column when running in single column mode. These mods allow a single column land simulation in a coupled configuration over an arbitrary column of the global grid.

Contributors other than yourself, if any: None.

CTSM Issues Fixed (include github issue #):
#1362

Are answers expected to change (and if so in what way)? No - This is new functionality

Any User Interface Changes (namelist or namelist defaults changes)? Namelist default addition of new ne3np4 boundary data for use with SCAM running the spectral element dycore.

Testing performed, if any:
CAM regression testing with active land all pass comparison to baseline showing these code mods do not affect answers.
CAM has a regression test for checking bit for bit reproducibility between a base 3d run of CAM against a single column run made with forcing captured from the base run. CTSM is an active component of these tests and exercises IC interpolation which demonstrates that the changes work as expected. These tests are run on Izumi and Derecho under the standard supported compilers.

@wwieder wwieder added tag: enh - new science next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jan 23, 2024
@wwieder
Copy link
Contributor

wwieder commented Jan 23, 2024

Thanks for opening this PR, @jtruesdal. This doesn't seem like a ton of code changes on the CLM side. Hopefully we can merge this relatively easily. Let's discuss this in our next SE meeting @ekluzek and decide who can look at this.

@ekluzek ekluzek self-requested a review January 25, 2024 17:18
@ekluzek ekluzek self-assigned this Jan 25, 2024
@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 25, 2024
@jtruesdal
Copy link
Contributor Author

@ekluzek @wwieder Just Checking in any timeframe for review?

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 23, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Feb 23, 2024

@jtruesdal thanks for the ping, appreciate it. We are working hard before the LMWG meeting next week on other things. So this will need to wait until after that. I've added our "next" label to make sure we talk about it in our next CTSM SE meeting. I skimmed over this, and there's enough that I need to comment on that I'll wait for later to do a full review. We are also working on a system of 2 week cycles (or sprints) for our planning. So we should review it in the next sprint, and at least give you an idea of what sprint this will slide into for your planning.

We had some PTSMODE tests that test SCAM for standalone CTSM previously (and with this coming in we should add more), but in looking at the latest code they must have been removed (accidentally I would guess). So we need to add those back in and also add some more testing for this in I cases. Since, this would be adding in new tests, that would mean this is a b4b task, and we might move it to the b4b-dev branch which should facilitate it getting to that branch sooner. But, I'm going to confirm that with my full review.

@wwieder wwieder added this to the CESM3 milestone Feb 23, 2024
@samsrabin
Copy link
Collaborator

Discussed at CTSM SE meeting today. Can't work on this now; @ekluzek and @wwieder to discuss.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Mar 21, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Jul 25, 2024

@jtruesdal sorry we haven't got to this in a long time. We figure this is a post science capability/functionality "chill" deadline thing and will get back to it after we are done with that deadline.

@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science and removed enh - new science labels Aug 8, 2024
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Aug 15, 2024
@samsrabin
Copy link
Collaborator

Now that dust is in, @ekluzek can get back to this.

@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 12, 2024
@jtruesdal
Copy link
Contributor Author

Thanks Sam and Erik! Please let me know what I can do to speed this along.

@slevis-lmwg
Copy link
Contributor

@jtruesdal @ekluzek
I came across this PR just now. It seems related to PR #2835 and its corresponding issue #2768, so I thought I would confirm. Do I need to take it into consideration somehow OR did we handle it with the most recent merge to #2835 (in which case this can close) OR some other scenario?

@jtruesdal
Copy link
Contributor Author

The warm start is a separate PR that Erik is working on. These datasets are needed to test the warm start PR and needs to go in first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Status: Slow roast (incremental or external progress)
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants