-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regression tests to run! #323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the tests going! I do have some change requests (which is mostly me backpedaling from previous things I asked you to do, sorry!), but hopefully it won't be too hard to implement. Of course please let me know if that is not the case. Thanks again!
@nusbaume thanks for your review. I also added the NL option to endrun on ncdata_check failures (and added it to the kessler test, which is currently the only one that has very small diffs) - if you could take a look at that, that'd be great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just two last requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me now. Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @peverwhee, thanks for getting this added!
One minor whitespace fix I think might be needed but nothing worth holding up this PR.
Tag name (required for release branches): sima0_00_001
Originator(s): peverwhee
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
closes #229 (Need ability for ncdata_check routines to end model run)
addresses #230 (Need CIME smoke tests for FPHYStest compset and various physics suites)
Updates the regression tests to actually run and compare against previous baselines.
Describe any changes made to build system:
Describe any changes made to the namelist:
List any changes to the defaults for the input datasets (e.g. boundary datasets): none
List all files MOVED and why:
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_mpas_derecho_nooutput/user_nl_cam
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_mpas_derecho_nooutput/shell_commands
cime_config/testdefs/testmods_dirs/cam/outfrq_held_suarez_derecho_nooutput/shell_commands
cime_config/testdefs/testmods_dirs/cam/outfrq_held_suarez_derecho_nooutput/user_nl_cam
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_derecho_nooutput/shell_commands
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_derecho_nooutput/user_nl_cam
cime_config/testdefs/testmods_dirs/cam/outfrq_tj2016_derecho_nooutput/user_nl_cam
cime_config/testdefs/testmods_dirs/cam/outfrq_tj2016_derecho_nooutput/shell_commands
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_se_cslam_derecho_nooutput/user_nl_cam
cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_se_cslam_derecho_nooutput/shell_commands
List all files added and what they do:
A cime_config/config_archive.xml
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>
)M cime_config/config_component.xml
M cime_config/config_compset.xml
M cime_config/config_pes.xml
M cime_config/namelist_definition_cam.xml
M cime_config/testdefs/testlist_cam.xml
M src/dynamics/tests/namelist_definition_analy_ic.xml
M src/physics/utils/phys_comp.F90
M src/physics/utils/physics_data.F90
M test/system/archive_baseline.sh
M test/system/test_driver.sh
If there are new failures (compared to the
test/existing-test-failures.txt
file),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
SMS_Ln2.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho
derecho/gnu/aux_sima:
SMS_Ln2.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced: n/a
CAM-SIMA date used for the baseline comparison tests if different than latest: first baselines!