Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove zeroth index from air_composition arrays #334

Open
nusbaume opened this issue Dec 11, 2024 · 0 comments
Open

Should remove zeroth index from air_composition arrays #334

nusbaume opened this issue Dec 11, 2024 · 0 comments
Labels
code clean-up Made code simpler, better, and/or easier to read.

Comments

@nusbaume
Copy link
Collaborator

Issue Type

Code Clean-up

Issue Description

Currently some of the allocated arrays in air_composition.F90 have a zero index where either N2 (if present) or average dry air values are set. While this does work and is "legal" Fortran, it doesn't match the general assumption that Fortran arrays always start at index one, and also with the philosophy that the atmospheric composition should be, as much as possible, set by the constituents provided by the chemistry and physics, instead of calculated internally in CAM-SIMA.

Given this, it would be good to modify the air_composition arrays and routines, and any routines that depend on them, to no longer need a zeroth index.

Will this change answers?

No

Will you be implementing this yourself?

Any Software Engineer can do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code clean-up Made code simpler, better, and/or easier to read.
Projects
Status: To Do
Development

No branches or pull requests

1 participant