Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename framerate attribute to sample_frequency #62

Open
psomhorst opened this issue Jul 26, 2024 · 1 comment
Open

Rename framerate attribute to sample_frequency #62

psomhorst opened this issue Jul 26, 2024 · 1 comment

Comments

@psomhorst
Copy link
Contributor

psomhorst commented Jul 26, 2024

In EIT-ALIVE/eitprocessing#290 we changed the EITData.framerate attribute to EITData.sample_frequency. This will go in effect probably in v.1.3.0.

For now, EITData.framerate will produce a DeprecationWarning.

Note that this issue should only be fixed after the dash will support eitprocessing>=v.1.3.0.

@wbaccinelli Is the dash fixed to a version of eitprocessing?

@wbaccinelli
Copy link
Collaborator

@psomhorst Yes, the eitprocessing version is fixed here. When upgrading the version to the new one, this issue has to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants