From a9557c9e7de2c57d92d9bab68a416a87d255cd3d Mon Sep 17 00:00:00 2001 From: Zach Bloomquist Date: Fri, 15 Feb 2019 17:41:15 -0500 Subject: [PATCH 1/7] Update outdated link in comment (#3109) --- lib/getProxyFromURI.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/getProxyFromURI.js b/lib/getProxyFromURI.js index 4633ba5f6..0b9b18e5a 100644 --- a/lib/getProxyFromURI.js +++ b/lib/getProxyFromURI.js @@ -40,7 +40,7 @@ function uriInNoProxy (uri, noProxy) { function getProxyFromURI (uri) { // Decide the proper request proxy to use based on the request URI object and the // environmental variables (NO_PROXY, HTTP_PROXY, etc.) - // respect NO_PROXY environment variables (see: http://lynx.isc.org/current/breakout/lynx_help/keystrokes/environments.html) + // respect NO_PROXY environment variables (see: https://lynx.invisible-island.net/lynx2.8.7/breakout/lynx_help/keystrokes/environments.html) var noProxy = process.env.NO_PROXY || process.env.no_proxy || '' From 7195b5064aac02532d4546c9ebcd1ec2508e6223 Mon Sep 17 00:00:00 2001 From: Jared Suttles Date: Mon, 25 Feb 2019 21:18:29 -0500 Subject: [PATCH 2/7] docs: adjust readme timeout argument description to be clearer (#3115) --- README.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index ce5791000..e89abc6a5 100644 --- a/README.md +++ b/README.md @@ -823,12 +823,9 @@ The first argument can be either a `url` or an `options` object. The only requir work around this, either use [`request.defaults`](#requestdefaultsoptions) with your pool options or create the pool object with the `maxSockets` property outside of the loop. -- `timeout` - integer containing number of milliseconds, controls two timeouts - - Time to wait for a server to send response headers (and start the response body) before aborting the request. - Note that if the underlying TCP connection cannot be established, - the OS-wide TCP connection timeout will overrule the `timeout` option ([the - default in Linux can be anywhere from 20-120 seconds][linux-timeout]). - - Sets the socket to timeout after `timeout` milliseconds of inactivity on the socket. +- `timeout` - integer containing number of milliseconds, controls two timeouts. + - **Read timeout**: Time to wait for a server to send response headers (and start the response body) before aborting the request. + - **Connection timeout**: Sets the socket to timeout after `timeout` milliseconds of inactivity. Note that increasing the timeout beyond the OS-wide TCP connection timeout will not have any effect ([the default in Linux can be anywhere from 20-120 seconds][linux-timeout]) [linux-timeout]: http://www.sekuda.com/overriding_the_default_linux_kernel_20_second_tcp_socket_connect_timeout From b0e9abb2f21a47783f96a8a408acc22ec51c1824 Mon Sep 17 00:00:00 2001 From: Tadashi Shigeoka Date: Mon, 1 Apr 2019 22:46:01 +0900 Subject: [PATCH 3/7] docs: :memo: Updated the Change Log for v2.88.0 (2018/08/10) (#3008) Used the following command: ``` github-changes -o request -r request -b master --date-format '(YYYY/MM/DD)' --only-pulls --use-commit-body --auth ``` --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 751514d28..d3ffcd00d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ ## Change Log +### v2.88.0 (2018/08/10) +- [#2996](https://github.com/request/request/pull/2996) fix(uuid): import versioned uuid (@kwonoj) +- [#2994](https://github.com/request/request/pull/2994) Update to oauth-sign 0.9.0 (@dlecocq) +- [#2993](https://github.com/request/request/pull/2993) Fix header tests (@simov) +- [#2904](https://github.com/request/request/pull/2904) #515, #2894 Strip port suffix from Host header if the protocol is known. (#2904) (@paambaati) +- [#2791](https://github.com/request/request/pull/2791) Improve AWS SigV4 support. (#2791) (@vikhyat) +- [#2977](https://github.com/request/request/pull/2977) Update test certificates (@simov) + ### v2.87.0 (2018/05/21) - [#2943](https://github.com/request/request/pull/2943) Replace hawk dependency with a local implemenation (#2943) (@hueniverse) From b3a218dc7b5689ce25be171e047f0d4f0eef8919 Mon Sep 17 00:00:00 2001 From: odykyi <24225497+odykyi@users.noreply.github.com> Date: Thu, 4 Apr 2019 03:30:35 +0300 Subject: [PATCH 4/7] Update README.md (#3023) --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index e89abc6a5..b71ea6428 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,7 @@ Request is designed to be the simplest way possible to make http calls. It suppo ```js const request = require('request'); request('http://www.google.com', function (error, response, body) { - console.log('error:', error); // Print the error if one occurred + console.error('error:', error); // Print the error if one occurred console.log('statusCode:', response && response.statusCode); // Print the response status code if a response was received console.log('body:', body); // Print the HTML for the Google homepage. }); @@ -86,7 +86,7 @@ To easily handle errors when streaming requests, listen to the `error` event bef request .get('http://mysite.com/doodle.png') .on('error', function(err) { - console.log(err) + console.error(err) }) .pipe(fs.createWriteStream('doodle.png')) ``` From 212570b6971a732b8dd9f3c73354bcdda158a737 Mon Sep 17 00:00:00 2001 From: Andres Rojas Date: Wed, 29 May 2019 21:53:20 +0200 Subject: [PATCH 5/7] Use nyc instead of istanbul (#3169) * Use nyc instead of istanbul istanbul package is not longer maintained * Have nyc output an lcov coverage report --- .gitignore | 1 + package.json | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 9a254ab59..214a2ec7c 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ coverage .idea npm-debug.log package-lock.json +.nyc_output \ No newline at end of file diff --git a/package.json b/package.json index 57a9c5454..86e4266bf 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "scripts": { "test": "npm run lint && npm run test-ci && npm run test-browser", "test-ci": "taper tests/test-*.js", - "test-cov": "istanbul cover tape tests/test-*.js", + "test-cov": "nyc --reporter=lcov tape tests/test-*.js", "test-browser": "node tests/browser/start.js", "lint": "standard" }, @@ -63,13 +63,13 @@ "codecov": "^3.0.4", "coveralls": "^3.0.2", "function-bind": "^1.0.2", - "istanbul": "^0.4.0", "karma": "^3.0.0", "karma-browserify": "^5.0.1", "karma-cli": "^1.0.0", "karma-coverage": "^1.0.0", "karma-phantomjs-launcher": "^1.0.0", "karma-tap": "^3.0.1", + "nyc": "^14.1.1", "phantomjs-prebuilt": "^2.1.3", "rimraf": "^2.2.8", "server-destroy": "^1.0.1", From aded7e4f8e57f6f33cf39d65634bfb822bfcb2c8 Mon Sep 17 00:00:00 2001 From: Mikeal Rogers Date: Tue, 11 Feb 2020 08:33:22 -0800 Subject: [PATCH 6/7] doc: note full deprecation (#3267) --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index b71ea6428..9da0eb7d8 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,9 @@ +# Deprecated! + +As of Feb 11th 2020, request is fully deprecated. No new changes are expected land. In fact, none have landed for some time. + +For more information about why request is deprecated and possible alternatives refer to +[this issue](https://github.com/request/request/issues/3142). # Request - Simplified HTTP client From 3c0cddc7c8eb60b470e9519da85896ed7ee0081e Mon Sep 17 00:00:00 2001 From: Gregor Martynus Date: Tue, 11 Feb 2020 15:39:46 -0800 Subject: [PATCH 7/7] README: typo in deprecation message (#3268) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9da0eb7d8..42290d5ce 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # Deprecated! -As of Feb 11th 2020, request is fully deprecated. No new changes are expected land. In fact, none have landed for some time. +As of Feb 11th 2020, request is fully deprecated. No new changes are expected to land. In fact, none have landed for some time. For more information about why request is deprecated and possible alternatives refer to [this issue](https://github.com/request/request/issues/3142).