Fix region_name parsing in elf32-extmap #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing section data for priting extended map information in map file, function elf32_collect_extmap_info was trying to retrieve region_name from the userdata field of bfd_section. extmap module has an internal representation of the userdata field not up to date with latest ld code, which writes a lang_output_section_statement_type inside this userdata field. To fix region name parsing, this code adds additional padding in the internal struct to be able to retrieve region name from userdata field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing section data for priting extended map information in map file, function elf32_collect_extmap_info was trying to retrieve region_name from the userdata field of bfd_section.
extmap module has an internal representation of the userdata field not up to date with latest ld code, which writes a lang_output_section_statement_type inside this userdata field. So if user generates map file during executable linking, the extended map table was printing gargage as memory region name, like shown here:
To fix region name parsing, this code adds additional padding in the internal struct to be able to retrieve region name from userdata field. Now memory region name should be correctly written in extended map listing: