Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disturbance being set to agriculture in runs with disturbance off #334

Open
mccabete opened this issue Oct 14, 2021 · 2 comments
Open

Disturbance being set to agriculture in runs with disturbance off #334

mccabete opened this issue Oct 14, 2021 · 2 comments

Comments

@mccabete
Copy link

I am running into an issue where my Dist_type is being set to 1. In the reproduction code, Dist_type = 1 is the agricultural case. None of my flags are allowing agriculture -- or any disturbance at all. Are the cases in the reproduction code up to date? Is one supposed to be Agriculture? I could imagine the code being updated but the cases not being updated.

Reproduction Code:

If agriculture is Dist_type 1, is there a place that flag could be being set other that the config.xml and/or the ED2IN?

mpaiao added a commit that referenced this issue Oct 14, 2021
It seems the reproduction code was not updated when pastures and croplands were split.  This fix now allows for pastures PFTs to reproduce in dist_type = 1, and cropland PFTs to reproduce in dist_type = 8.  I believe this addresses the fix on #334 (thanks @mccabete for spotting it).
@mpaiao
Copy link
Contributor

mpaiao commented Oct 14, 2021

@mccabete You are spot on, and I just made a quick pull request about this. Thanks for catching this!

Pastures and croplands used to be lumped together in dist_type 1, but we now distinguish them (pastures are dist_type = 1 and croplands are dist_type = 8). Somehow this routine was not updated to assign the right PFTs for pastures and croplands (my bad). Not sure if this is the issue or if it is something else, but this was a bug in the code and needed to be fixed. Let me know if this fixes the lack of reproduction.

@mccabete
Copy link
Author

mpaiao's PR to fix the cases is here: for more discussion of this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants