-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert class templates to Kokkos memory spaces #585
Conversation
9564598
to
49176e5
Compare
49176e5
to
c30d506
Compare
b35bb09
to
9f88936
Compare
c35376e
to
58f7fd4
Compare
0ae494d
to
48aaf86
Compare
003ba5e
to
727e585
Compare
(also updates example/test View and Array templates)
727e585
to
33d8091
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please explain why template classes on Memoryspace
and function on ExecutiionSpace
?
Overall, we only need the memory space to store the class Views, then the execution space to execute the member functions kernels (except in a few very specific instances). This mostly clarifies what’s needed where and when we use the default I mentioned in the comment above |
Failures unrelated |
Convert all class template parameters to memory space rather than device type to close #407.