From 54ab3665681edeb5e5d99ff44e2988fb8b4dcf1f Mon Sep 17 00:00:00 2001
From: James Foucar <jgfouca@sandia.gov>
Date: Tue, 4 Jun 2024 12:55:31 -0600
Subject: [PATCH] Fix valgrind errors in eamxx_homme_iop.cpp

We were running off the end of a couple views.
---
 components/eamxx/src/dynamics/homme/eamxx_homme_iop.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/components/eamxx/src/dynamics/homme/eamxx_homme_iop.cpp b/components/eamxx/src/dynamics/homme/eamxx_homme_iop.cpp
index 66f73b5ac9a..eaf65a69cda 100644
--- a/components/eamxx/src/dynamics/homme/eamxx_homme_iop.cpp
+++ b/components/eamxx/src/dynamics/homme/eamxx_homme_iop.cpp
@@ -594,9 +594,9 @@ apply_iop_forcing(const Real dt)
             // Restrict nudging of T and qv to certain levels if requested by user
             // IOP pressure variable is in unitis of [Pa], while iop_nudge_tq_low/high
             // is in units of [hPa], thus convert iop_nudge_tq_low/high
-            Mask nudge_level;
-            for (int p=0; p<Pack::n; ++p) {
-              const auto lev = k*Pack::n + p;
+            Mask nudge_level(false);
+            int max_size = hyam.size();
+            for (int lev=k*Pack::n, p = 0; p < Pack::n && lev < max_size; ++lev, ++p) {
               const auto pressure_from_iop = hyam(lev)*ps0 + hybm(lev)*ps_iop;
               nudge_level.set(p, pressure_from_iop <= iop_nudge_tq_low*100
                                  and