Add support for planar periodic meshes #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planar Periodic Testingimport mosaic
import matplotlib.pyplot as plt
def test_periodic(descriptor, ds, loc):
fig, ax = plt.subplots()
mosaic.polypcolor(ax, descriptor, ds.indexToCellID * 0.0, ec='k', cmap='binary')
mosaic.polypcolor(ax, descriptor, ds[f"indexTo{loc}ID"], alpha=0.5, ec='tab:orange')
ax.scatter(ds[f"x{loc}"], ds[f"y{loc}"], color="tab:blue")
ax.set_title(f"{loc} Patches")
ds = mosaic.datasets.open_dataset("doubly_periodic_4x4")
descriptor = mosaic.Descriptor(ds)
for loc in ["Cell", "Edge", "Vertex"]:
test_periodic(descriptor, ds, loc)
plt.show()Cell patches:
Edges patches:
Vertex patches
|
andrewdnolan
force-pushed
the
periodic_planar
branch
2 times, most recently
from
9de3628 to
b5bba02
Compare
Further testing is need to move the spherical wrapping into the new method used by planar periodic meshes.
andrewdnolan
force-pushed
the
periodic_planar
branch
from
b5bba02 to
df0de3b
Compare
WIP: There's debugging that's needed for vertex patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for planar periodic meshes, by streamlining and abstracting the spherical wrapping functionality so that it works to both planar and spherical meshes. For this to work, I've added getter/setter methods for the period attributes that handle the planar periodic / spherical meshes details appropriately. This has also dramatically simplified the spherical wrapping procedure, which was unduly complicated (and insufficient) previously. Testing of new the spherical wrapping for vertex patches has revealed a bug in #12, which produces invalid geometries for vertices along culled boundaries. When these invalid geometries intersect the map projection boundary,
cartopystruggles with them resulting in the patches spanning the entire plot area. This bug is fixed as part of this PR. Finally, for testing purposes this PR also adds a small planar periodic mesh to the datasets database.Fixes #15.