Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add new land variable handlers for supporting ILAMB #242

Open
chengzhuzhang opened this issue Feb 21, 2024 · 8 comments
Open
Labels
enhancement New feature or request

Comments

@chengzhuzhang
Copy link
Collaborator

chengzhuzhang commented Feb 21, 2024

Is your feature request related to a problem?

As discussed at meetings with land developers, right now only a subset of ilamb required variables can be handled by zppy through e3sm_to_cmip. @dmricciuto provided a conversion table that from CLM2 /home/ac.ricciuto/models/ilamb_processing/alm2ilamb_wkflow/clm_to_mip

I don’t know if the listed variables are still relevant. Before implementing into e3sm_to_cmip, we need a land develop to have a review. @thorntonpe hey Peter, could you recommended someone? We get multiple requests from land team to produce more CMIP variables from zppy. Pinging, @hydrotian @evasinha @daliwang @qzhu-lbl ...

As a reference, here listed land variables we already supported.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@chengzhuzhang chengzhuzhang added the enhancement New feature or request label Feb 21, 2024
@evasinha
Copy link

@chengzhuzhang I am happy to help with the review. Please let me know how you want me to proceed.

@chengzhuzhang
Copy link
Collaborator Author

chengzhuzhang commented Feb 22, 2024

Thank you @evasinha ! Could you go through the variable list here /home/ac.ricciuto/models/ilamb_processing/alm2ilamb_wkflow/clm_to_mip, and add relevant variables to the table here from row 28?
And we can then start change the e3sm_to_cmip code for implementing the new variables handlers.

@evasinha
Copy link

@chengzhuzhang I have added additional land variables to the table.

@chengzhuzhang
Copy link
Collaborator Author

@evasinha Thanks! Could you also take care removing duplicated entries from row 28, and resolve conflict formula? I notice for example LAI has different conversion formula somehow. Finally I realized the original table missed a unit column. It would be great if you can add it.

@thorntonpe
Copy link

I met today with Nate Collier (part of the iLAMB team) to get the full list of variables that they need, the units they expect, and the descriptions of the variables. I am iterating with him on a couple outstanding questions, and then I will compare my notes against the table linked above. I have a note that some help is needed generating the variable handlers in e3sm_to_cmip. Once we have the full list of iLAMB variables confirmed I can circle back to that. Note that there will be a difference between the variables we want for time series and mapped diagnostics, and the ones needed for iLAMB. I should be able to provide more feedback after confirming the iLAMB list.

@chengzhuzhang
Copy link
Collaborator Author

@thorntonpe thanks for the updates!
Regarding to the list of variables for time series and maps, the variables put together for mapps generated by e3sm_diags was from a separate practice. For the time series plots in zppy, we can try generating some prioritized land variables and to generalize for more if needed.

@evasinha
Copy link

@chengzhuzhang

  1. I have removed duplicate rows where there was no conflict in formula. When the formula were different I have kept the duplicate row but added a note saying different formula.
  2. I have added a column for CMIP units.

@chengzhuzhang
Copy link
Collaborator Author

@evasinha Thank you for updating the table! We will be able to start the code change once get reviewed and confirmed by Peter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants