Should we remove the FindAVX cmake module and its use in EkatSetCompilersFlags?

[bartgol]

Question

All that FindAVX.cmake does is probing /proc/cpuinfo for avx extensions, and set the AVX_VERSION cmake variable accordingly. Later, if the compiler is either Intel or GNU, EkatSetCompilerFlags will add the correct avx compiler flag, depending on AVX_VERSION.

I would consider removing this feature, for the following reasons:

1. It only works if the node where we compile has the same architecture as the compute node.
2. Only works for Intel and GNU.
3. Kokkos_ARCH_XYZ already provides the vectorization flags, also for other compilers.
4. It's yet another low level detail to maintain (rather than rely on kokkos).