Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPAS-Seaice standalone makefile is broken #6138

Closed
akturner opened this issue Jan 3, 2024 · 1 comment · Fixed by #6134
Closed

MPAS-Seaice standalone makefile is broken #6138

akturner opened this issue Jan 3, 2024 · 1 comment · Fixed by #6134
Labels
bug mpas-framework mpas-seaice

Comments

@akturner
Copy link
Contributor

akturner commented Jan 3, 2024

The MPAS-Seaice standalone makefile (https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-framework/Makefile) is broken and does not work. It appears there is a missing "endif" on the line after this: https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-framework/Makefile#L630
@xylar
Copy link
Contributor

xylar commented Jan 4, 2024

@akturner, I think this might be the same issue that @mark-petersen reported in #6133 and is fixing in #6134

@xylar xylar mentioned this issue Jan 4, 2024
Merged
jonbob added a commit that referenced this issue Jan 9, 2024
@jonbob
Merge branch 'mark-petersen/mpas/standalone-compile-fix' into next (PR …
5d25bf6 
…#6134)

Fix MPAS standalone compile issues

These two small changes allow MPAS components to compile in stand-alone
mode. It should not affect E3SM compile or simulations. The fixes are:
* A missing endif was added to the Makefile
* A redundant corelist declaration was removed from mpas.F because it
  was added to mpas_subdriver.F in PR Introduce MOAB coupler interfaces
  and update moab driver #5979, and the subdriver is used by mpas.F.
These fixes should work for ocean, sea ice, and MALI cores.

Fixes #6133
Fixes #6138

[BFB]
@jonbob jonbob closed this as completed in 7f7920b Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mpas-framework mpas-seaice
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MPAS standalone compile issues mark-petersen/E3SM
2 participants
@xylar @akturner