You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While debugging the hanging issue on Perlmutter @dqwu and I realized that a related problem was that there are duplicate calls to ncd_putatt in the land model code that deals with restart files. I think there may be more of this type of duplicate call elsewhere, but I'm not that familiar with the land code so I'm not sure.
The instance of this that I stumbled on starts with the call to restartvar. There's 2 interface routines for restartvar , both of which take a "units" argument. Each of these routines calls ncd_defvar , which ALSO takes a "units" argument that gets used in a call to ncd_putatt. Then farther down in the restartvar routines there is a check that "units" is present and if so added a duplicate call to ncd_putatt.
It seems like a harmless fix to get rid of one of these, but I don't understand the code enough to know if this would affect some other part of the code.
The text was updated successfully, but these errors were encountered:
While debugging the hanging issue on Perlmutter @dqwu and I realized that a related problem was that there are duplicate calls to
ncd_putatt
in the land model code that deals with restart files. I think there may be more of this type of duplicate call elsewhere, but I'm not that familiar with the land code so I'm not sure.The instance of this that I stumbled on starts with the call to
restartvar
. There's 2 interface routines forrestartvar
, both of which take a "units" argument. Each of these routines callsncd_defvar
, which ALSO takes a "units" argument that gets used in a call toncd_putatt
. Then farther down in therestartvar
routines there is a check that "units" is present and if so added a duplicate call toncd_putatt
.It seems like a harmless fix to get rid of one of these, but I don't understand the code enough to know if this would affect some other part of the code.
The text was updated successfully, but these errors were encountered: