Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "put_att" calls in ELM #5288

Open
whannah1 opened this issue Nov 10, 2022 · 0 comments
Open

Duplicate "put_att" calls in ELM #5288

whannah1 opened this issue Nov 10, 2022 · 0 comments
Assignees
Labels

Comments

@whannah1
Copy link
Contributor

While debugging the hanging issue on Perlmutter @dqwu and I realized that a related problem was that there are duplicate calls to ncd_putatt in the land model code that deals with restart files. I think there may be more of this type of duplicate call elsewhere, but I'm not that familiar with the land code so I'm not sure.

The instance of this that I stumbled on starts with the call to restartvar. There's 2 interface routines for restartvar , both of which take a "units" argument. Each of these routines calls ncd_defvar , which ALSO takes a "units" argument that gets used in a call to ncd_putatt. Then farther down in the restartvar routines there is a check that "units" is present and if so added a duplicate call to ncd_putatt.

It seems like a harmless fix to get rid of one of these, but I don't understand the code enough to know if this would affect some other part of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants