-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openkit for Server Side Tracing #204
Comments
Hi Abhishek, thanks for the question. Unfortunately, OpenKit was not designed for this use case, to trace incoming web requests. It's also not trivial to get this in, as we would need to extend the protocol that is used. The appropriate way would be the OneAgent SDK or the OneAgent itself. I will forward this ticket to the appropriate stakeholders. They will be able to give more details about Vert.X support. Best regards |
Hi, I'm not familiar with Vert.X to be honest, but from the way it's described on the website (event driven, non-blocking) it is most likely not a good fit for the OneAgent SDK tracers and their thread-affinity. from https://github.com/Dynatrace/OneAgent-SDK-for-java:
You could ask on Dynatrace Answers about Vert.X and see if others have that requirement as well, though. Best regards |
Hi Wolfganf, Stefen I understand tha One Agent SDK has some kind of thread-affinity, and hence wanted to fall back upon OpenKit. The challenge I have in my hand is that we have a microservices based application where all services are good and dynatrace abiding citizens.
I know One Agent has already mentioned that this is not even in the roadmap. Is there a way this can come in the roadmap ? vertx seems to be working well with Jaeger and hence there's a definite affinity of the team to switch |
Hi Abhishek, can you share a very simple code snippet of how your web request looks like? We just took a very quick look at Vert.X sample codes: Looking at those two examples, you should be able to use OneAgent SDK for tracing the incoming and outgoing web requests if the SDK tracer is started and ended into the handler methods. You should also make sure that no other out-of-the-box sensor is already starting the outgoing web request. In that case, you would need to deactivate this out-of-the-box sensor. Sonja |
Hi Sonja.
I am off on vacation this week and next week in a workshop. However I am on
this. Just give me some time to get the sample up for this thread.
Regards,
Abhishek
…On Fri, Oct 25, 2019 at 2:53 PM Sonja Chèvre ***@***.***> wrote:
Hi Abhishek,
can you share a very simple code snippet of how your web request looks
like? We just took a very quick look at Vert.X sample codes:
-
https://github.com/vert-x3/vertx-examples/blob/master/core-examples/src/main/java/io/vertx/example/core/http/simple/Client.java
-
https://github.com/vert-x3/vertx-examples/blob/master/core-examples/src/main/java/io/vertx/example/core/http/simple/Server.java
Looking at those two examples, you should be able to use OneAgent SDK for
tracing the incoming and outgoing web requests if the SDK tracer is started
and ended into the handler methods.
You should also make sure that no other out-of-the-box sensor is already
starting the outgoing web request. In that case, you would need to
deactivate this out-of-the-box sensor.
Sonja
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#204?email_source=notifications&email_token=ACKK3Z22ADR3RUM7LEH22IDQQK3KLA5CNFSM4JE66SUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHYP6I#issuecomment-546277369>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKK3Z7VMN3DGXK3VBVW6LLQQK3KLANCNFSM4JE66SUA>
.
|
Hi Sonja, |
Merge in OP/openkit-java from feature/ONE-54799-pump-version-to-2.3.0-SNAPSHOT to main * commit 'd090fd59b8ee9d4aa8912d868fc29623dac3a4d4': Pump version to 2.3.0-SNAPSHOT GitOrigin-RevId: a7cc215f447a5d0bb5945fe05eb24045157068bb
Hey,
Can this library be used to do the server side tracing. I know the tracer which exists is for outgoing web request equivalent, however if we extend the library we might be able to write an incoming web request tracer.
The reason I ask is because oneagent SDK is not behaving well with vertx due to the way thread models work in vertx. The oneagent jumbles up the purepath.
Will we be able to extend this kit to construct the same by extending this SDK.
Abhishek
The text was updated successfully, but these errors were encountered: