Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Logging and Errors #12

Open
DanielWright opened this issue Mar 31, 2016 · 4 comments
Open

Better Logging and Errors #12

DanielWright opened this issue Mar 31, 2016 · 4 comments

Comments

@DanielWright
Copy link
Contributor

TBD

@peterberkenbosch
Copy link
Contributor

Adding standard Rails.logger?
Errors will bubble up when processing though.

@DanielWright
Copy link
Contributor Author

At a base level, I was thinking of at least a counter of shipments pushed, much as the Wombat client used to do:

Pushed Shipments: 453
Errors: 2

Beyond that, I think it's important to integrate a backoffice dashboard which surfaces errors a bit to admins. It'll be useful for us to look at backtraces on Sentry, but something a little more user-friendly will need to be made available for customer-service purposes.

@peterberkenbosch
Copy link
Contributor

In the current implementation we push per shipment, there is no concept of batches. A shipment is either successfully pushed or not. We could wrap some counters in the rake task where this is implemented maybe.

Personally I would not add any UI here so we can keep this gem light and focussed on the core functionality, communication with fosdick.
when using sidekiq for example there will be an dashboard that will show the jobs that did not ran successfully.

@DanielWright
Copy link
Contributor Author

Yep, you're right, delegating that responsibility to the host app makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants