Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assigned] Speaker name is not displayed on SearchSessionsFragment screen. #528

Closed
nukka123 opened this issue Jan 29, 2018 · 4 comments · Fixed by #536
Closed

[Assigned] Speaker name is not displayed on SearchSessionsFragment screen. #528

nukka123 opened this issue Jan 29, 2018 · 4 comments · Fixed by #536

Comments

@nukka123
Copy link
Contributor

nukka123 commented Jan 29, 2018

Overview (Required)

This is bug repot.

before (#439) now (name is not displayed)
search_ok search_fail

Links

@takahirom
Copy link
Member

Thanks 👍 That's bug

@nukka123
Copy link
Contributor Author

The cause was found out.

item_horizontal_session.xml

<io.github.droidkaigi.confsched2018.presentation.common.view.SpeakersSummaryLayout
    android:layout_width="0dp"
    android:layout_height="wrap_content"
    app:layout_constraintBottom_toBottomOf="parent"
    app:layout_constraintEnd_toStartOf="@id/favorite"
    app:layout_constraintStart_toStartOf="parent"
    app:layout_constraintTop_toBottomOf="@id/title"
    app:speakers="@{session.speakers}"
    />

-> app:textColor is not specified.

SpeakersSummaryLayout.kt

val defaultAttributes = CustomAttributes(
        textColor = 0
)

-> This means full transparent color.

@nukka123
Copy link
Contributor Author

nukka123 commented Jan 30, 2018

ok. i try to fix it.

@takahirom
Copy link
Member

Thanks!!!😂😂

@takahirom takahirom changed the title Speaker name is not displayed on SearchSessionsFragment screen. [Assigned] Speaker name is not displayed on SearchSessionsFragment screen. Jan 30, 2018
@konifar konifar added this to the 1.2.0 milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants