Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and view counts highly inaccurate #19

Open
rebeltaz opened this issue Aug 18, 2019 · 4 comments
Open

Download and view counts highly inaccurate #19

rebeltaz opened this issue Aug 18, 2019 · 4 comments

Comments

@rebeltaz
Copy link

rebeltaz commented Aug 18, 2019

The [Downloads] count is highly inaccurate. Oftentimes, that number will be incremented with each viewing of the page, whether a file is downloaded or not. Sometimes the increment of that counter doesn't seem to be tied to any activity whatsoever.

Edit by @DrLex0:

Both the main download counter on Thing pages, as well as the separate download counts in the ‘files’ tab have problems:

  • Most obvious bug: simply (re)loading the ‘files’ tab of a Thing, increments the download count of all the files in the tab. This makes those counts meaningless.
  • The main counter goes up each time someone clicks the “Download all files” button, which makes sense. However, it is also incremented each time a separate file is downloaded from the files tab. Therefore if a Thing has 10 parts, and someone downloads all parts separately, the downloads are incremented by 10 although this should only be counted as one download.

I think it makes the most sense to:

  1. increment both the global counter, as well as the count for each separate part, when the “Download all files” button is clicked.
  2. only increment the count for a separate part if it is clicked in the files tab list. This means that if this is correctly implemented, the download counts for separate parts must always be more than or equal to the global download count.
@DrLex0
Copy link
Owner

DrLex0 commented Aug 18, 2019

Ah yes, that's an obvious one I missed. Thanks for adding!

@positron96
Copy link

Could it be that bots and spiders are downloading files like crazy?

@DrLex0
Copy link
Owner

DrLex0 commented Sep 5, 2019

@positron96 Perhaps, but it's also as @rebeltaz says: simply viewing the files tab will increment download counts even if you don't download anything.

@DrLex0
Copy link
Owner

DrLex0 commented Nov 3, 2019

Users report that since about October 30th, view and download counts are now completely broken, see for instance:
https://www.thingiverse.com/groups/engineering/forums/general/topic:40406

@DrLex0 DrLex0 changed the title Downloads Counts Highly Inaccurate Download and view counts highly inaccurate Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants