-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDP. plan-b end, only unified plan #359
Comments
Me too.. |
We fixed this in our fork, please see this commit. Because we're so far downstream I haven't applied a pull request, but the fix works: L1kMakes@f0432ec |
Hello. Can there be any solution? Thank you very much. |
This a bit of a pain (I left my previous job where I was working on this and had to batch a ton of changes in 1 big commit). We found and fixed the bug, it's in this commit: If you scroll down it's in this file: src/tinyMEDIA/src/tmedia_session_jsep.js It's in line 450. Basically the WebRTC functionality for "addTrack" changed to creating an additional RTPSender, rather than just appending a track. You have to switch to the "replaceTrack" method, which is async. We have it working, but the way we batched our commits we can't really push to upstream. |
Thank you very much for the information. Failed to parse header: From: 10121<sip:[email protected]:443>;tag=u4vFvLgd2yiMIptinb5l Any ideas? |
Not sure; what is that tag? Do you know what info is being sent for the user/callerID? That's in the header, and I see "NameAddr.Parse" is part of the error. |
Thanks for the quick reply. Thank you very much. |
Hello again. |
Hmm, not sure. It could be around the way the webRTC stream reattaches, but it worked in our tests; the interesting thing is the changes to webRTC we made in that patch came from Mozilla's API documentation. I'm no longer with the org I was developing this at, so testing is a little trickier. I would want to add a breakpoint to that bit of the api, and inspect the objects to make sure there's only 1 Sender and see what the track id's are. |
Hello.
Does anyone have a solution to get it to work with sdp on the unified plan?
Chrome in its beta version (Version 95.0.4638.69 (Official Build) (64 bits)) no longer accepts plan-b
Thanks.
The text was updated successfully, but these errors were encountered: