Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User's date in Spread Sheet title instead of server's date #50

Open
engfragui opened this issue Sep 13, 2022 · 1 comment
Open

User's date in Spread Sheet title instead of server's date #50

engfragui opened this issue Sep 13, 2022 · 1 comment

Comments

@engfragui
Copy link
Contributor

engfragui commented Sep 13, 2022

src/services/actions.service.spec.ts's createSheetName uses the server's date to name the newly created Spread Sheet:

new Date().toLocaleDateString(),
)

It might be confusing for people to see that the Google Spread Sheet is called Todoist Export: {project title} from 9/13/2022 and maybe for them (i.e. New Zealand now) is already 9/14/2022.

This might be a trivial fix, especially if we already have some utility functions that retrieve the user's local date/time.

@scottlovegrove
Copy link
Contributor

This should be easily doable, we deal with dates a lot in the other extensions and we can use the user's timezone as that's passed to the server from the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants