Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optionParent Select.js custom element #6643

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from

Conversation

majioa
Copy link

@majioa majioa commented May 22, 2021

Proposed changes

  • optionParent Select.js custom element feature, allowing to explicitly reassign parent for select's options, required for the novel React.

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

+ optionParent Select.js custom element feature, allowing to explicitly
  reassign parent for select's options, required for the novel React.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant