Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication errors using pusher + redis drivers #4

Open
zlodes opened this issue Nov 21, 2023 · 2 comments
Open

Authentication errors using pusher + redis drivers #4

zlodes opened this issue Nov 21, 2023 · 2 comments

Comments

@zlodes
Copy link

zlodes commented Nov 21, 2023

Hi!

Thank you for your work at first!
Trying to use the package, faced an issue with authentication of private channel using two drivers needs authentication: pusher + redis.

At first, we should call validAuthenticationResponse withing all the drivers in use (both) and then use that driver in auth method.
Also I found that there is no any test.

I suggest to use WeakMap to memo the current request to driver map.
I can implement that, but it needs PHP 8.0 as minimum.

I think it's time to bump versions of laravel broadcaster dependency + php version + add tests.
Then we can bump a major version of the package.

What do you think?

@kyrylokulyhin
Copy link
Collaborator

Hello @zlodes
Thank you for interest to this package. Happy to see it is helpful not just for our use case.

Agree on bumping package version. It would be nice if you can prepare PR with upgrade and required Auth changes.

@zlodes
Copy link
Author

zlodes commented Nov 21, 2023

@kirjwuk 🙏🏻

We're going to migrate from Laravel Echo Server using redis connection driver to Soketi (Pusher-compatible).
But we have several frontends using it. Trying to do a smooth migration.

I have a little draft. Want to write some tests at first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants