Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with Laravel 8 #30

Open
didix16 opened this issue Apr 19, 2021 · 3 comments
Open

Make it compatible with Laravel 8 #30

didix16 opened this issue Apr 19, 2021 · 3 comments

Comments

@didix16
Copy link

didix16 commented Apr 19, 2021

Hi.

I'm trying to make it work with my Laravel 8 installation but it seems this package is outdated with new Laravel version.

I'm having problems with runCommand method from all of your commands.

// This is the expected method interface

protected function runCommand($command, $path, OutputInterface $output)

// this is the current interface

protected function runCommand($command, $path)

// These are the errors that i get from:

 ErrorException 

  Declaration of devmtm\NovaCustomViews\ViewsCommand::runCommand($command, $path) should be compatible with Illuminate\Console\Command::runCommand($command, array $arguments, Symfony\Component\Console\Output\OutputInterface $output)

  at vendor/digitalcloud/nova-custom-views/src/commands/ViewsCommand.php:212
 ErrorException 

  Declaration of devmtm\NovaCustomViews\DashboardViewCommand::runCommand($command, $path) should be compatible with Illuminate\Console\Command::runCommand($command, array $arguments, Symfony\Component\Console\Output\OutputInterface $output)

  at vendor/digitalcloud/nova-custom-views/src/commands/DashboardViewCommand.php:163

Etc...

Edit

BTW: Process class interface should be updated.

Its constructor expects an array and now a string is given

Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given,

End edit

Could you make it compatible with Laravel 8?

Thank you so much

@xUJYx
Copy link
Contributor

xUJYx commented Jul 20, 2021

Done, awaiting PR merge

@didix16
Copy link
Author

didix16 commented Jul 22, 2021

Thank you so much!

@xUJYx
Copy link
Contributor

xUJYx commented Jul 22, 2021

Thank you so much!

If you`ll find some errors or bugs - pls write to me. I tested my code, but will appreciate for more tests from other people...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants