Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next cleanup time and commands left headers to /health API #52

Open
lucifercr07 opened this issue Oct 27, 2024 · 10 comments
Open

Add next cleanup time and commands left headers to /health API #52

lucifercr07 opened this issue Oct 27, 2024 · 10 comments
Assignees

Comments

@lucifercr07
Copy link
Contributor

  • Add next cleanup time and commands left headers to /health API
  • This change is required to be done so that UI can call /health API to render these values instead of depending on command triggers.
  • Add unit/integration tests for the same
@rishavvajpayee
Copy link
Contributor

hey i can take this up

@aasifkhan7
Copy link
Contributor

@rishavvajpayee, could you provide an update on this? The issue is currently blocking the progress on DiceDB/alloy#78

@rishavvajpayee
Copy link
Contributor

hey working on the tests, will be submitting the PR by EOD @aasifkhan7

@aasifkhan7
Copy link
Contributor

Any updates @rishavvajpayee ?

@rishavvajpayee
Copy link
Contributor

hey @aasifkhan7 i've added the PR for this you can read through the code and see what headers are required and start implementing the FE till its merged
: #54

@aasifkhan7
Copy link
Contributor

@lucifercr07 Could you please assign this to me? The development on this issue is complete, and this issue is currently blocking it.

@lucifercr07
Copy link
Contributor Author

@aasifkhan7 assigned, thanks.

@lucifercr07
Copy link
Contributor Author

@aasifkhan7 any updates on this, please let me know if you want any help on this.

@aasifkhan7
Copy link
Contributor

I'll share the PR soon @lucifercr07

@aasifkhan7
Copy link
Contributor

aasifkhan7 commented Dec 12, 2024

Here is the pull request link: #58 @lucifercr07.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants