Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PING command doc #115

Closed
wants to merge 1 commit into from
Closed

Updated PING command doc #115

wants to merge 1 commit into from

Conversation

abrahamvineel
Copy link

This PR resolves #38

Changes Made

  • Refactored headings to match as per syntax requirement in issue Audit and make documentation for command PING consistent #38
  • Refactored formatting for Parameters, Return values , Examples sections
  • Added 127.0.0.1:7379> in all CLI implementation examples
  • Refactored cli output error messages to reflect current CLI error message syntaxes in Examples and Errors sections
  • Refactored Examples section to include examples of different values

abrahamvineel
abrahamvineel commented Sep 28, 2024
View reviewed changes
src/content/docs/commands/PING.md

## Additional Notes
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer-note: removed Additional Notes section as it was not present in the #38. Do let me know if you want me to add it back.

@abrahamvineel
Copy link
Author

Hi @arpitbbhayani can you please review the changes.
Thanks in advance.

@arpitbbhayani
Copy link
Contributor

@abrahamvineel looks good. can you raise a PR in Dice repo. I just moved docs there.
You can find it under docs directory in main dice repo.

@abrahamvineel
Copy link
Author

@arpitbbhayani thanks I will raise the PR to Dice repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit and make documentation for command PING consistent
2 participants
@abrahamvineel @arpitbbhayani