Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap momentjs for another date-io compatible library #3022

Open
2 of 4 tasks
adamcarr opened this issue Aug 6, 2020 · 4 comments
Open
2 of 4 tasks

Swap momentjs for another date-io compatible library #3022

adamcarr opened this issue Aug 6, 2020 · 4 comments
Assignees
Labels
enhancement Scheduler The DevExtreme Reactive Scheduler component

Comments

@adamcarr
Copy link

adamcarr commented Aug 6, 2020

  • I have searched this repository's issues and believe that this is not a duplicate.

I'm using ...

  • React Grid
  • React Chart
  • React Scheduler

Description

We are looking to start using React Scheduler and it has a direct dependency on momentjs which we are trying to avoid due to performance and package bloat. Your dependency on momentjs seems to be via date-io which is an abstraction that may allow swapping out to other libraries. Is this something you currently support or are considering supporting in the future?

Environment

  • devextreme-reactive: 2.7.0
  • react: 16.13.1
  • browser: all
  • bootstrap: none
  • react-bootstrap: none
  • material-ui: none
@LazyLahtak LazyLahtak added question Scheduler The DevExtreme Reactive Scheduler component labels Aug 7, 2020
@MaximKudriavtsev MaximKudriavtsev self-assigned this Aug 7, 2020
@MaximKudriavtsev
Copy link
Contributor

Hi @adamcarr,

We are using the moment.js library inside our core package for complex calculations. Unfortunately, it's not possible to change this library.

I assigned an enhancement tag to this issue and we will consider it in future planning.

Can I ask you about what scheduler component your team will prefer and why? This information will help us to become better.

@adamcarr
Copy link
Author

We are going to use the React Scheduler in @devexpress/dx-react-scheduler. We will likely use many of the plugins already available as well. We are building a meeting booking system across multiple user accounts and this control greatly simplifies the amount of work we need to do. The question about moment.js is around trying to optimize our package payload and up until now we have been able to avoid moment.js.

@MaximKudriavtsev
Copy link
Contributor

Thank you for the clarification.

@FedeBev
Copy link

FedeBev commented Apr 30, 2021

Hi there,

since moment is now kind of deprecated, maybe this issue should be reconsidered.
In my opinion Luxon should allow a smooth migration, but obviously only someone with a deep knowledge of the library can say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Scheduler The DevExtreme Reactive Scheduler component
Projects
None yet
Development

No branches or pull requests

5 participants