feat: Menu component #333

lycHub · 2023-09-29T07:25:06Z

新增 menu component

foolmadao · 2023-10-08T09:24:15Z

第二个demo展开收起，标题和内容注明是横向的展开收缩，明确一些。
最后一个demo自动展开选中菜单，感觉场景不是很常用，只是为了初始化展开的化直接数据控制就好了，建议删除。

lycHub · 2023-10-10T06:19:35Z

第二个demo展开收起，标题和内容注明是横向的展开收缩，明确一些。最后一个demo自动展开选中菜单，感觉场景不是很常用，只是为了初始化展开的化直接数据控制就好了，建议删除。

已改

lycHub · 2023-10-10T06:20:37Z

u感觉没啥必要

我说的是横向的collapse

collapsed是用户自己控制 [collapsed]的不用再暴露事件

lycHub · 2023-10-10T06:24:07Z

我研究了下，用ngTemplateOutlet递归有下面三个问题，

所以目前的api设计只能自行封装递归组件，其实也挺简单的，copy下demo代码就行 😅

devui/menu/menu.component.scss

devui/button/button.component.html

devui/menu/sub-menu.component.html

devui/menu/menu.component.scss

Simplelegant · 2023-10-13T08:25:04Z

还有些细节问题再处理下就差不多了

递归菜单中有横向滚动条
由于首项和尾项有4px margin 菜单上下的留白变为了24px，看下是取消首尾4px margin 还是减小菜单的padding，预期是上下留白20px
好多文件中有注释代码，请删除
demo细节有空的话你也可以再过一下看还有没有没发现的遗漏问题

lycHub · 2023-10-13T12:15:56Z

还有些细节问题再处理下就差不多了

递归菜单中有横向滚动条

由于首项和尾项有4px margin 菜单上下的留白变为了24px，看下是取消首尾4px margin 还是减小菜单的padding，预期是上下留白20px

好多文件中有注释代码，请删除

demo细节有空的话你也可以再过一下看还有没有没发现的遗漏问题

已改，滚动条暂时视觉隐藏了，一时没找到啥好方法，我再看看

lycHub · 2023-10-14T15:56:35Z

都改完菜单宽度还是让用户设置，避免滚动条

Simplelegant · 2023-10-17T11:01:34Z

devui/menu/demo/basic/basic.component.html

@@ -0,0 +1,32 @@
+<div class="demo-menu" style="width: 388px; overflow-x: auto">


menu的宽度现在是怎么设置呢，是调整此处外围容器的宽度还是调整--devui-menu-width
刚试了下调小外层容器宽度会有水平滚动条，而且内容和箭头会重叠

我试了各种title长度和层级深度，没找到一种比较兼容的样式😭
所以全放开了，外围容器宽度，title换行还是省略号啥的就让用户根据具体菜单自行调整吧😂

我试了各种title长度和层级深度，没找到一种比较兼容的样式😭 所以全放开了，外围容器宽度，title换行还是省略号啥的就让用户根据具体菜单自行调整吧😂

这样感觉用户使用成本很高，菜单文本不同宽度就要去适配外层容器宽度和省略方案

给title加了省略号

src/app/app.component.scss

Simplelegant · 2023-10-27T06:36:35Z

devui/shared/devui-online-ide/devui-online-ide.service.ts

@@ -84,7 +84,7 @@ export class DevuiOnlineIdeService {
  }

  getFiles(sourceData: DevuiSourceData[], ide: 'StackBlitz' | 'CodeSandbox' = 'StackBlitz'): any {
-    console.log(sourceData);
+    // console.log(sourceData);


还有对其它地方代码的修改，请恢复

还有很多console.log()没有删除，请全面排查

devui/package.json

lycHub added 30 commits September 20, 2023 23:54

feat: add menu branch

b7701e2

feat: 初始化菜单文档

c20bdda

feat: menu基本样式

386108b

feat: 递归menu

4cd1a53

feat: 折叠menu

c9c161f

fix: button点击两次只触发一次的bug

3d22d1b

feat: menu animation

bf8f4ba

feat: 菜单自定义ui

26c08af

fix: menu 动画bug

77a524b

style: 整理menu代码

2700a45

fix: 菜单状态bug

271af58

feat: 完成菜单弹出交互

d0c24e0

fix: 使用takeUntilDestroyed

4d567a1

docs: menu demos

dfeaf2a

docs: menu api docs

e911809

fix: fix docs

b82f2cb

fix: 嵌套menu bugs

a7ef300

fix: menu item click

c045dfd

feat: add menu branch

5b986aa

feat: 初始化菜单文档

3cac755

feat: menu基本样式

a836019

feat: 递归menu

5420f66

feat: 折叠menu

11ffc99

fix: button点击两次只触发一次的bug

660a9ca

feat: menu animation

8d0251d

feat: 菜单自定义ui

b1558f4

fix: menu 动画bug

f3aaf8d

style: 整理menu代码

1e8ae96

fix: 菜单状态bug

e7f26c8

feat: 完成菜单弹出交互

00c144d

lycHub added 3 commits October 8, 2023 21:44

fix: 改文案

0445da9

Merge branch 'master' into menu-component

339718d

fix: menu 折叠保持展开

bbfb54d

Simplelegant reviewed Oct 11, 2023

View reviewed changes

devui/menu/menu.component.scss Outdated Show resolved Hide resolved

devui/button/button.component.html Outdated Show resolved Hide resolved

devui/menu/sub-menu.component.html Outdated Show resolved Hide resolved

lycHub added 2 commits October 11, 2023 20:17

feat: menu样式优化，还原button组件代码

eb34441

feat: border-radius变量

4044ba4

Simplelegant reviewed Oct 12, 2023

View reviewed changes

devui/menu/menu.component.scss Outdated Show resolved Hide resolved

fix: menu细节优化

53b7656

fix: menn优化

f5924d2

fix(menu): 优化样式，submenu加上[cdkConnectedOverlayPush]

2f03e23

fix(menu): menu 调整 icon-gap

e13388d

Simplelegant reviewed Oct 17, 2023

View reviewed changes

fix(menu): menu title 加省略号

ee8a493

Simplelegant previously approved these changes Oct 20, 2023

View reviewed changes

Simplelegant reviewed Oct 27, 2023

View reviewed changes

fix: 还原menu以外的代码，删掉log

96a6a8d

lycHub dismissed Simplelegant’s stale review via 96a6a8d October 27, 2023 09:48

fix(app.component.scss): 删掉.devui-menu的class

3e9b9a8

Simplelegant reviewed Oct 30, 2023

View reviewed changes

devui/package.json Outdated Show resolved Hide resolved

fix(devui/package.json) 删掉 @ngrx/component

43f0fd7

Simplelegant approved these changes Nov 1, 2023

View reviewed changes

wangyaju approved these changes Nov 1, 2023

View reviewed changes

wangyaju merged commit d26efe4 into DevCloudFE:master Nov 1, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Menu component #333

feat: Menu component #333

lycHub commented Sep 29, 2023

foolmadao commented Oct 8, 2023

lycHub commented Oct 10, 2023

lycHub commented Oct 10, 2023

lycHub commented Oct 10, 2023

Simplelegant commented Oct 13, 2023 •

edited

Loading

lycHub commented Oct 13, 2023

lycHub commented Oct 14, 2023

Simplelegant Oct 17, 2023

lycHub Oct 17, 2023 •

edited

Loading

Simplelegant Oct 19, 2023

lycHub Oct 19, 2023

Simplelegant Oct 27, 2023 •

edited

Loading

		@@ -0,0 +1,32 @@
		<div class="demo-menu" style="width: 388px; overflow-x: auto">

feat: Menu component #333

feat: Menu component #333

Conversation

lycHub commented Sep 29, 2023

foolmadao commented Oct 8, 2023

lycHub commented Oct 10, 2023

lycHub commented Oct 10, 2023

lycHub commented Oct 10, 2023

Simplelegant commented Oct 13, 2023 • edited Loading

lycHub commented Oct 13, 2023

lycHub commented Oct 14, 2023

Simplelegant Oct 17, 2023

Choose a reason for hiding this comment

lycHub Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

Simplelegant Oct 19, 2023

Choose a reason for hiding this comment

lycHub Oct 19, 2023

Choose a reason for hiding this comment

Simplelegant Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

Simplelegant commented Oct 13, 2023 •

edited

Loading

lycHub Oct 17, 2023 •

edited

Loading

Simplelegant Oct 27, 2023 •

edited

Loading