Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Discord validation #1205

Open
sadukie opened this issue Oct 30, 2023 · 5 comments
Open

Update Discord validation #1205

sadukie opened this issue Oct 30, 2023 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@sadukie
Copy link
Collaborator

sadukie commented Oct 30, 2023

Need to update the Discord validation:

image

You no longer need to use the # and 4-digits - per Discord update.
@sadukie sadukie added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Oct 30, 2023
Micah-Bello pushed a commit to Micah-Bello/DevBetterWeb that referenced this issue Jan 20, 2024
Remove discord username validation DevBetterCom#1205
753cf63
@Micah-Bello
Copy link

I'd like to create a PR for this issue

@sadukie
Copy link
Collaborator Author

sadukie commented Jan 22, 2024

@ardalis Heads up on this one.

@Micah-Bello We don't want just the validation to be removed. What should happen is:

  • Discord username should be optional. (unless this is required for devBetter)
  • Validation still needs to be in place to check that it meets the guidelines. The validation needs updated to meet the latest in naming guidelines from Discord.

Tagging in @ShadyNagy since he helped us address this in another one of our codebases.

@ardalis
Copy link
Collaborator

ardalis commented Apr 23, 2024

We still need this - just ran into it again today.

@ardalis
Copy link
Collaborator

ardalis commented May 10, 2024

@canro91 can you take this one?

@canro91
Copy link
Contributor

canro91 commented May 10, 2024

@ardalis Sure, I'm taking it.

@canro91 canro91 mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sadukie @ardalis @canro91 @Micah-Bello