PR feedback

DestinyItemManager · Jan 5, 2024 · 6ec5cf6 · 6ec5cf6
1 parent 3914b1b
commit 6ec5cf6
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 4 deletions.
diff --git a/src/app/settings/CustomStatsSettings.m.scss b/src/app/settings/CustomStatsSettings.m.scss
@@ -72,8 +72,9 @@
 }
 
 .identifyingInfo {
-  composes: flexRow from '../dim-ui/common.m.scss';
+  composes: flexWrap from '../dim-ui/common.m.scss';
   align-items: center;
+  justify-content: flex-end;
   gap: 8px;
 
   img {
@@ -86,6 +87,7 @@
 
 .label {
   flex-grow: 1;
+  text-wrap: balance;
 }
 
 .classIcon {
@@ -116,8 +118,9 @@
 
 // all info for a custom stat, without the editing controls
 .customStatView {
-  composes: flexWrap from '../dim-ui/common.m.scss';
+  composes: flexRow from '../dim-ui/common.m.scss';
   align-items: center;
+  gap: 8px;
 }
 
 @keyframes pulse-border {

diff --git a/src/app/settings/CustomStatsSettings.tsx b/src/app/settings/CustomStatsSettings.tsx
@@ -277,7 +277,7 @@ function CustomStatView({
   setEditing: React.Dispatch<React.SetStateAction<number>>;
 }) {
   return (
-    <div className={clsx(styles.customStatView, styles.identifyingInfo)}>
+    <div className={styles.customStatView}>
       <button
         type="button"
         className="dim-button"

diff --git a/src/app/settings/Spreadsheets.m.scss b/src/app/settings/Spreadsheets.m.scss
@@ -0,0 +1,4 @@
+.buttons {
+  composes: flexWrap from '../dim-ui/common.m.scss';
+  gap: 4px;
+}
diff --git a/src/app/settings/Spreadsheets.m.scss.d.ts b/src/app/settings/Spreadsheets.m.scss.d.ts
diff --git a/src/app/settings/Spreadsheets.tsx b/src/app/settings/Spreadsheets.tsx
@@ -10,6 +10,7 @@ import { DropzoneOptions } from 'react-dropzone';
 import { useSelector } from 'react-redux';
 import { AppIcon, spreadsheetIcon } from '../shell/icons';
 import { settingClass } from './SettingsPage';
+import styles from './Spreadsheets.m.scss';
 
 export default function Spreadsheets() {
   const dispatch = useThunkDispatch();
@@ -43,7 +44,7 @@ export default function Spreadsheets() {
         <label htmlFor="spreadsheetLinks" title={t('Settings.ExportSSHelp')}>
           {t('Settings.ExportSS')}
         </label>
-        <div>
+        <div className={styles.buttons}>
           <button
             type="button"
             className="dim-button"